Re: [sdcc-devel] [ sdcc-Bugs-3475630 ] Wrong code generated for writing to the structure

[Philipp K. K. <pk...@sp...>]

On 22.01.2012 13:26, Maarten Brock wrote:
> Philipp,
> 
> Could you please run at least one regression test model 
> for every target before committing new tests? And 
> preferably all regression tests? Revision 7247 is broken 
> for all mcs51 configurations. Large variables as in 
> bug3475630.c must be made global or static and placed in 
> __xdata as the stack is too limited.
> 
> And then bug3475656.c also fails for mcs51-model-large 
> with an undefined global.

OK. I've also opended bug #3477347, fixing which will speed up
regression testing.

> 
> Finally could you please configure subversion such that 
> new files are committed with native line endings?

Done. I've added the extra line

*.hpp = svn:eol-style=native;svn:keywords=Author Date Id Revision

To my config and at
https://sourceforge.net/apps/trac/sdcc/wiki/SDCC%20coding%20style

> And 
> also beware of using TAB's.

Does the not using tabs rule also apply to regression tests? I've
usually tried to keep the test close to what the bug submitter attached
to the bug report.

Philipp