[sdcc-devel] [ sdcc-Patches-3410396 ] PIC16: Patch for i2c start/stop incompleteness

[SourceForge.net <no...@so...>]

Patches item #3410396, was opened at 2011-09-16 11:42
Message generated for change (Settings changed) made by diegoherranz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=3410396&group_id=599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Deleted
Resolution: None
Priority: 5
Private: No
Submitted By: Diego Herranz (diegoherranz)
Assigned to: Nobody/Anonymous (nobody)
Summary: PIC16: Patch for i2c start/stop incompleteness

Initial Comment:
Patch for bug https://sourceforge.net/tracker/?func=detail&atid=100599&aid=3368894&group_id=599

----------------------------------------------------------------------

>Comment By: Diego Herranz (diegoherranz)
Date: 2011-09-23 22:43

Message:
Finally I think it's not a bug. So this patch is deleted.

Any way, while working with this patch I discovered some other problems
with i2c which I will upload in a different patch.

----------------------------------------------------------------------

Comment By: Diego Herranz (diegoherranz)
Date: 2011-09-18 17:40

Message:
i2c.diff file updated.

- Now, check for SSPCON2bits.SEN and SSPCON2bits.PEN to be cleared is also
made in macros I2C_START() and I2C_STOP()  respectively
(device/include/pic16/i2c.h)

- And while I was at it, I found that macros with multiple statements in
device/include/pic16/i2c.h used semicolon. Now comma operator is used
instead (http://en.wikipedia.org/wiki/C_preprocessor#Multiple_statements)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300599&aid=3410396&group_id=599