Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#2043 z180 assembler tst

closed-fixed
Lee Morrison
z80 port (188)
5
2014-12-03
2012-06-13
No

The z80 assembler when in .hc64 mode, accepts the tst instruction only with the a operand ommitted, e.g.

tst a, #0x05 is rejected, but tst #0x05 works.

This is in contrast to other instructions where the assembler accepts both forms. The assembler should accept tst with explicit a operand.

Philipp

Discussion

  • Thanks Lee, for fixing this in revision #7899. I also added a regression test in revision #7909, which will test for this once the smallopts branch is merged.

    Philipp

     
    • status: open --> closed-fixed
     
  • Maarten Brock
    Maarten Brock
    2012-06-16

    I cannot believe this is fixed. Compilation generates a warning about use of an uninitialised variable t1. And looking at the code this t1 and the if-statement around it seem to indicate something else was meant.

    Also, please do not forget to set Assigned and Group when closing a report.

     
  • Maarten Brock
    Maarten Brock
    2012-06-16

    • status: closed-fixed --> open-fixed
     
  • Maarten,

    I think Lee fixed the issue you mentioned in #7921, so this bug report could be closed. However I cannot assign tracker items to enigmalee, the drop-down list simply doesn't contain the entry.

    Philipp

     
  • Maarten Brock
    Maarten Brock
    2012-06-19

    I've given Lee tech&admin rights on the tracker system. Now I hope he will assign the item to himself and set the group and status.

     
  • Lee Morrison
    Lee Morrison
    2012-06-19

    Tracker Admin is present for me now. I've done a bit of testing to verify that errors are
    now generated in the case that Maarten noticed. So I think this is fixed.

     
  • Lee Morrison
    Lee Morrison
    2012-06-19

    • milestone: --> fixed
    • assigned_to: nobody --> enigmalee
    • status: open-fixed --> closed-fixed