#1156 Error in header at89c51ed2.h

closed-fixed
nobody
None
5
2006-07-10
2006-06-21
Steven Borley
No

in at89c51ed2.h name of register is wrong

line 134
__sfr __at (0xB7) IP0H; //Interrupt Priority 0 HIGH

should read
__sfr __at (0xB7) IPH0; //Interrupt Priority 0 HIGH

ref. Atmel datasheet for AT89C51RD2/ED2 Rev. 4235C–8051–08/03

Discussion

  • Logged In: YES
    user_id=603650

    Thanks for the report! Fixed in revision 4244.

     
    • status: open --> closed
     
  • Logged In: YES
    user_id=589052

    Hi,

    this could also be a typo in the Atmel datasheet?

    - other registers within at89c51ed2.h (CCAP0H, CCAP0L,
    ...) and the bit definitions for IP0H registers use
    the postfix notation (f.e. #define PX0H 0x01)

    - the name IP0H is also used in P89LPC901.h, 89LPC922.h,
    P89LPC932.h and p89v51rd2.h

    - using L or H as postfix instead of inserting them
    can be considered good practice because in an
    alphabetical index the related registers
    (or register bit definitions) show up next.

    So I'd vote for changing back. As I'm unsure how to proceed
    I set this report to pending again.

     
    • status: closed --> pending
     
  • Maarten Brock
    Maarten Brock
    2006-06-22

    Logged In: YES
    user_id=888171

    Atmel is pretty consistent in this one. They use IPH0,
    IPL0, IPH1 and IPL1 throughout the datasheet. Also in the
    header files they provide themselves it's called IPH0. So
    no typo here in my opinion.

     
  • Steven Borley
    Steven Borley
    2006-07-09

    Logged In: YES
    user_id=1270801

    I agree with Maarten on this. We should follow Atmel's datasheet.
    I stand by my original report.

     
  • Steven Borley
    Steven Borley
    2006-07-09

    • status: pending --> open
     
  • Logged In: YES
    user_id=589052

    Ok, fine. Will stay as requested in your report and as fixed
    in revision 4244.

     
    • status: open --> closed-fixed