Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#6671 RINGWORLD2: Crash during final (?) confrontation

closed-fixed
Paul Gilbert
None
5
2014-07-10
2014-07-02
No

During the final (?) confrontation, when Seeker defiantly states that he will not give up the cube, the game may crash with the following assertion:

scummvm: engines/tsage/converse.cpp:251: virtual void TsAGE::SequenceManager::signal(): Assertion `_sceneObject' failed.
Aborted

It seems to depend on who is the active character when I enter the room. I couldn't reproduce it as Quinn, but so far it happens every time as Seeker. (I haven't tried as Miranda.)

1 Attachments

Discussion

  • digitall
    digitall
    2014-07-06

    • assigned_to: Paul Gilbert
     
  • digitall
    digitall
    2014-07-06

    Reliably replicated as described with attached savegame on latest git master using Linux x86_64.

    Checked with valgrind. No issues seen.

    This assertion is occurring as the _sceneObject being assigned is NULL and thus when it is dereferenced later in the script, it will fail, hence the non-null assertion.

    I have added some debug output to the converse class to track the SequenceManager object's _objectList[] member state. Attaching this patch and two traces from the bad case (with Seeker) and the good case (with Quinn, but have also tested with Miranda and the output is identical).

    The main point of difference / deviation seems to be that in the bad case:
    SequenceManager::remove(_resNum:3402)
    SequenceManager::attached(_resNum:3400)

    slightly before the point of failure, whereas in the good case, this is:
    SequenceManager::remove(_resNum:3402)
    SequenceManager::attached(_resNum:3408)

     
  • digitall
    digitall
    2014-07-06

    Patch and logs follow:

     
    Attachments
  • digitall
    digitall
    2014-07-06

    Bad log:

     
  • digitall
    digitall
    2014-07-06

    Good log:

     
  • digitall
    digitall
    2014-07-06

    Sorry about the multiple comments... Allura seems to not allow multiple attachments per comment despite saying "Add attachments" i.e. plural. SIGH.

     
  • Paul Gilbert
    Paul Gilbert
    2014-07-10

    • status: open --> closed-fixed
     
  • Paul Gilbert
    Paul Gilbert
    2014-07-10

    Thanks for the assistance with the analysis. It made figuring out the problem much easier.