Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#5983 SCI: LONGBOW: Wrong shade of grey for cursors

closed-fixed
Graphics (902)
5
2012-04-29
2012-02-18
Johann Walter
No

Using ScummVM 1.5.0git2420-g975801b on Win 7 64 bit. Playing Conquests of the Longbow (DOS, English, v 1.0 with official Sierra patch).

The cursors in Longbow mostly use black and white, but some of them (bow, look and especially talk) have some grey pixels. As shown in the attached file, the shade of grey used by ScummVM is much too dark (left is the original interpreter in DOSBox, right is ScummVM).

Discussion

  • Johann Walter
    Johann Walter
    2012-02-18

    Left is original, right is ScummVM

     
    Attachments
  • This is due to the grey color used in the cursor palette.

    Adding the following hack in GfxCursor::kernelSetShape() after setting colorMapping[3] (similar to the LB1 one) makes the colors match, but it's not the right way to address this issue:
    if (g_sci->getGameId() == GID_LONGBOW)
    colorMapping[3] = _palette->matchColor(223, 223, 223); // Light Grey

    We need to determine if this color is hardcoded in the interpreter or set from the scripts themselves

     
    • labels: --> Graphics
    • assigned_to: nobody --> thebluegr
    • status: open --> closed-fixed
     
  • Added the aforementioned hack in 24e57808aa946ad38379b43ca205af6ef151c66a, which fixes the issue.

    Closing