Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#4929 SCUMM: Mute setting does not work

closed-fixed
None
9
2010-09-20
2010-07-21
No

ScummVM trunk r51098
Linux/amd64 with g++ 4.4.4
Games tried: Monkey 2 and The Dig

The "mute" setting is not respected by SCUMM at all, neither when using it while the game is running via the GMM nor on startup.

I tried adopting ScummEngine::syncSoundSettings so that it behaves the same as Engine::syncSoundSettings when the "mute" config key is set to "true", but that only fixes digital iMuse it seems. At least then the mute option worked fine in The Dig, while not at all in Monkey 2 (tried with AdLib).

Discussion

    • assigned_to: nobody --> sev
    • status: open --> closed-fixed
     
  • Fixed in SVN.

     
  • Reopening this bug report since Monkey 2 is still not fixed. Just start up Monkey 2 (with AdLib) and check the mute box in the GMM, the SFX in the copy protection won't be gone and you still have music in the intro. It seems all it does currently is to lower the sound volume, if you can't hear any music/sfx just turn up your speaker volume

     
    • status: closed-fixed --> open
     
  • M. Kiewitz
    M. Kiewitz
    2010-09-01

    noticed that as well in lsl5. When mute is enabled music is still playing but with a really low volume, although we correctly set the actual volume to be 0.

     
    • priority: 5 --> 9
    • assigned_to: sev --> nobody
     
  • Raising priority. This is a release-critical bug.

     
  • This is a general problem (or rather misunderstanding) of the OPL commands. It seems the OPL chips only feature a "very low" volume setting as 0, but no silence. So all engines which setup the OPL emulator as kPlainSoundType and only sending 0 as volume will still have (quite silent) output for OPL though.

     
  • I am closing the bugreport then. Feel free to open another one (Adlib to respect volume 0), but it will be not release critical.

    I just retested the game, at least with my speakers the sound is not heard with mute setting.

     
    • assigned_to: nobody --> sev
    • status: open --> closed-fixed
     
  • Actually I tried my MT-32 now and it isn't fully muted there either, so I guess it's not an AdLib driver specific problem, but rather all our sound code assuming that a midi volume of 0 means no sound, which isn't really represented by 0 as it seems.