#277 Tagtrees names and descriptions not correctly translated

open-accepted
None
5
2007-06-16
2006-11-15
No

On system with no native gnu sed (as for example Mac OS X), the transformation in data/tagtrees/Makefile.am and consequently Makefile.in does not work, as it uses an OR attribute specific to gnu sed between name and description.

%.tagtree: %.xml.in
sed 's/\([^_]\)_\(name\|description\)/\1\2/g' < $< > $@

Would it be possible to make a change so that it works also with non gnu sed, as I did not see that gnu sed is required at run time, unless I've missed something?

Possible patch is attached.

Discussion

  • Possible patch for tagtrees names and description

     
    Attachments
  • Logged In: YES
    user_id=552580
    Originator: YES

    Notice that the patch uses /usr/bin/sed to pick up the native non gnu sed, and not a @PREFIX@/bin/sed which may be a gnu sed. It may be changed to sed or @PREFIX@/bin/sed, or even a configure flag to pick the right one, though I don't think it is important here, since it should work for any sed.

     
  • David A Knight
    David A Knight
    2007-06-16

    Logged In: YES
    user_id=736
    Originator: NO

    Thanks, patch applied, although still using sed rather than /usr/bin/sed as it still works with gnu sed.

     
  • David A Knight
    David A Knight
    2007-06-16

    • assigned_to: nobody --> davek
    • status: open --> open-accepted