Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#4 scponly cannot build on platforms which lack GNU getopt

open
nobody
None
5
2008-05-11
2008-05-11
Stuart Shelton
No

'configure' sets HAVE_GETOPT and HAVE_GETOPT_H, but the code doesn't honour these defines.

IRIX, for example, has /usr/include/getopt.h but this isn't GNU-compatible. This means that scponly fails to build due to the references to 'struct option' from line 88 of scponly.c.

This is a regression from version 4.6, which used 'cmd_arg_t' and did build successfully on IRIX.

(Also, on this platform, 'bzero' is defined in strings.h rather than string.h, so this should really be checked for and included.)

Discussion

  • Stuart Shelton
    Stuart Shelton
    2008-05-11

    Logged In: YES
    user_id=25125
    Originator: YES

    Notes:

    scponly-4.6:

    helper.c has '#elif' without a conditional on line 191: this should be '#else'.
    Build requires '-lgen' on IRIX (for 'basename') - might this also effect Solaris & HP/UX?
    Bulld ignores $LDFLAGS, so '-lgen' must be added to CFLAGS.

    scponly-4.8:

    scponly.c lacks a return statement for non-void 'function process_ssh_request' at line 875.
    scponly.h defines extern functions 'strbeg' & 'strend' as inline.