#949 Allow specifying Find in Files directory

Completed
closed
Neil Hodgson
SciTE (231)
5
2012-08-31
2012-08-16
Jakub Vrána
No

I quite often need to search the whole directory regardless in which subdirectory I am in. For example in SciTE: I am in scite/win32 directory but I want to search also in scite/src and basically all other directories. There is currently no way how to make it default.

The attached patch introduces find.in.directory property which will be usually set in SciTEDirectory.properties. It is used to prefill the directory field in Find in Files. User can still change it.

Discussion

  • Jakub Vrána
    Jakub Vrána
    2012-08-16

    scite

     
  • Neil Hodgson
    Neil Hodgson
    2012-08-17

    • assigned_to: nobody --> nyamatongwe
     
  • Neil Hodgson
    Neil Hodgson
    2012-08-17

    There have been times when I want the find in files directory to not follow the current file, such as when reading a downloaded project. I did try adding a property to lock the find in files directory field so it would remain static except when the user changed it explicitly but found it didn't really integrate well into the flow of activities. A more interactive approach may work better than a property allowing it to change more easily and not require leaving behind SciTE.properties/SciTEDirectory.properties files.

    Choosing to retain a directory when its picked doesn't feel like the right sequence since you are thinking about the search at that point. Possibly have a "Use previous directory" checkbox where clicking it on automatically fills in the directory from the previous run. Subsequent runs use that directory unless the user explicitly changes it.

    While I haven't built your patch on GTK+, it appears to be missing a '{' on the else.

     
  • Neil Hodgson
    Neil Hodgson
    2012-08-22

    Committed with a different implementation on GTK+.

     
  • Neil Hodgson
    Neil Hodgson
    2012-08-22

    • milestone: --> Completed
     
  • Jakub Vrána
    Jakub Vrána
    2012-08-29

    Thanks for committing and sorry about the bug in GTK implementation. I am quite happy with this solution because I have several projects, all of them already have SciTEDirectory.properties and I almost always want to find in the whole project.

    Your proposal can be useful in different flows but I need this: If I open any file in a project, I want to search in this whole project. "Use previous directory" wouldn't be useful for me as project root was never "previous directory".

     
  • Neil Hodgson
    Neil Hodgson
    2012-08-29

    If you want a specific directory then you choose it. Next time its the "previous directory".

     
  • Neil Hodgson
    Neil Hodgson
    2012-08-31

    • status: open --> closed