#912 Support opening file:// by Ctrl+Shift+O

Completed
closed
Neil Hodgson
SciTE (231)
5
2012-03-08
2012-02-28
Jakub Vrána
No

Some tools (mainly XML related) print filenames in format file:///filename.ext.

This patch adds support for this format in Open Selected command. Plus it should fix a buffer overflow.

Discussion

  • Neil Hodgson
    Neil Hodgson
    2012-02-29

    • assigned_to: nobody --> nyamatongwe
     
  • Neil Hodgson
    Neil Hodgson
    2012-02-29

    The buffer overflow check is wrong since selectedFilename may have been moved from the beginning of targetFilename due to "file://" so there are less than MAX_PATH characters available.

    Its easy to make this sort of mistake when working with fixed buffers, so to make this overflow safe it would be better to switch to a dynamic string type - SString or std::string or FilePath. Should also be separate patches, one for overflow safety and one for file:// as this makes it easier to work out why things have changed in source control.

     
  • Jakub Vrána
    Jakub Vrána
    2012-03-01

    You are right, appending new patch.

     
  • Jakub Vrána
    Jakub Vrána
    2012-03-01

    scite

     
    Attachments
  • Neil Hodgson
    Neil Hodgson
    2012-03-01

    Committed.

     
  • Neil Hodgson
    Neil Hodgson
    2012-03-01

    • milestone: --> Completed
     
  • Neil Hodgson
    Neil Hodgson
    2012-03-08

    • status: open --> closed