#131 some useful enchancements

open
Neil Hodgson
None
1
2004-03-30
2004-03-29
Sergey Philippov
No

1. Add "function" highlighting style in c/pascal/other
functional languages -- non-keyword identifier followed
by opening paren
2. Add transparent background marker style -- for
changing text background without altering fore colors
and font styles -- usefull for marking syntax constructs
and blocks of code in non-line orientated debuggers
(such as in Smalltalk)
3. Add SCN_NEWLINE notification for easy hooking to
autoident.
4. Add SCI_SETSTYLEDTEXT to set contents of control
with styling
5. On windows register control class with default
background set to GetSysColorBrush(COLOR_WINDOW)

p.s. sorry for bad English, it is not my native language

Discussion

    • priority: 5 --> 1
     
  • Neil Hodgson
    Neil Hodgson
    2004-03-30

    Logged In: YES
    user_id=12579

    1. I suppose some people may like this but I'd want it to be
    an option to retain compatibility. There is a question of
    how hard it tries to see ahead to find a '(' as these are
    sometimes on the next line.
    2. A reasonable idea but the precedence or merging of
    background colour needs to be defined.
    3. Not a significant improvement.
    4. SCI_CLEARALL, SCI_ADDSTYLEDTEXT
    5. Why? It is currently set to NULL so that the only code
    that draws in the window is Scintilla.

     
  • Neil Hodgson
    Neil Hodgson
    2004-03-30

    • assigned_to: nobody --> nyamatongwe
     
  • Logged In: YES
    user_id=868704

    1. I think that lookup for open paren or space and open paren
    will be enough. Anyway open paren on next line is almost
    unreadable :)
    2. I think that selection coloring algorithm is suitable because
    of this marker type usage (emphasizing blocks of code).
    Items 3 and 4 are useful in systems where controlling code
    and UI lives in different threads.
    5. For using default window color instead of white when
    default style's bgcolor is not set.

     
  • Neil Hodgson
    Neil Hodgson
    2004-04-01

    Logged In: YES
    user_id=12579

    > Items 3 and 4 are useful in systems where
    > controlling code and UI lives in different threads.

    I can't see 3 helping much for multithreading. For 4,
    most multithreaded locking of groups of operations should be
    deferred to the application or we would have to wrap a very
    large set of potentially interesting operation sequences. Is
    there a really strong use case here for SCI_SETSTYLEDTEXT?

     
  • Logged In: YES
    user_id=868704

    Both of these features just useful for multithreading, not
    necessary: item 3 avoids marshaling SCNotification to
    controlling thread, item 4 avoids one point of synchronization
    (between SCI_CLEARALL and SCI_ADDSTYLEDTEXT).
    Also SCI_SETSTYLEDTEXT can be added for consistensy with
    SCI_SETTEXT. First of all, Scintilla is a syntax coloring editor,
    not just a plain text editor :)