#1527 VHDL 2008 /* */-style comments are not recognized

Bug
closed-fixed
Neil Hodgson
3
2014-09-30
2013-09-16
Cousteau
No

VHDL 2008 allows C-style /* */ comments in addition to -- ones.

-- This is a comment
/* This is a VHDL-2008 comment, but Scintilla (and most VHDL parsers 
 * apparently) doesn't recognize it */

This comment style has not been quite spread yet anyway, so it's probably not very urgent to implement, but it would be nice to have it anyway.

Discussion

  • Neil Hodgson
    Neil Hodgson
    2013-09-17

    • labels: --> scintilla, vhdl
    • status: open --> open-accepted
    • assigned_to: Neil Hodgson
     
  • Neil Hodgson
    Neil Hodgson
    2013-09-17

    I won't be working on this myself.

     
  • danselmi
    danselmi
    2014-08-12

    I implemented this feature.

    See attached patch.

    What else can I do to get it applied?

     
    Last edit: danselmi 2014-08-13
    • Neil Hodgson
      Neil Hodgson
      2014-08-18

      The patch isn't cleanly applying with several hunks failing.

      --------------------------- Command Error ---------------------------
      abort: patch failed to apply
      ---------------------------
      Hunk #1 FAILED at 118
      Hunk #3 FAILED at 156
      Hunk #6 FAILED at 265
      Hunk #7 FAILED at 290
      Hunk #8 FAILED at 302
      5 out of 9 hunks FAILED -- saving rejects to file lexers/LexVHDL.cxx.rej
      transaction abort!
      rollback completed

      [Code: 255]
      --------------------------- OK ---------------------------

      It says it is based on revision 9854 but mainline Scintilla only goes up to 5254. Try applying the changes to the current Scintilla release and attach the resulting LexVHDL.cxx to this issue.

       
  • danselmi
    danselmi
    2014-08-19

    better with this one?

     
    Last edit: danselmi 2014-08-19
  • Neil Hodgson
    Neil Hodgson
    2014-08-20

    • status: open-accepted --> open-fixed
     
  • Neil Hodgson
    Neil Hodgson
    2014-08-20

    Committed as [be468d].

    Currently credited to danselmi. Please advise if a different name or names should be used.

     

    Related

    Commit: [be468d]

  • Neil Hodgson
    Neil Hodgson
    2014-09-30

    • status: open-fixed --> closed-fixed