Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#1459 Improvements to Haskell Lexer

Bug
closed-fixed
Neil Hodgson
3
2013-07-21
2013-04-03
kudah
No
  • Added support for MagicHash extension (lexer.haskell.allow.hash)
  • $ and # are now colored as operators.
  • .0 and -0 are now properly colored as operator and a number, not as just number.
  • Operators starting with double dash (e.g ---->) are properly colored as operators, not comments.
  • Added pragma highlighting.
  • Added basic C-preprocessor highlighting.
  • Qualified names (e.g. ABC.xyz) are now properly highlighted as identifiers, not types.
  • Qualified operators (e.g. ABC.<$>) are now properly highlighted as operators.
  • Operator . is now properly highlighted as an operator, not part of the identifier, when applied to a qualified and an unqualified value (e.g. Abc.xyz.yzx <- last one is an operator)
  • Operators starting with ':' are now properly highlighted as type constructors, not operators.
  • "family" after "data" is highlighted, as per TypeFamilies.
1 Attachments

Discussion

<< < 1 .. 6 7 8 (Page 8 of 8)
  • kudah
    kudah
    2013-05-28

    Huh? What does the release schedule have to do with merging to the main repo?

     
    • Neil Hodgson
      Neil Hodgson
      2013-05-28

      Why does it matter to you when the patch is applied? Its not going into 3.3.3 because it arrived after 3.3.3 was announced and the first RC was distributed.

       
      • kudah
        kudah
        2013-05-28

        Why does it matter to you when the patch is applied?

        And why does it matter to you? If 3.3.3 is freezed, like you say, then it should be on its own branch or tag, master branch's progress shouldn't be obstructed. But whatever, it doesn't matter except I'd rather have performance degradation in 3.3.2 reversed sooner.

         
        Last edit: kudah 2013-05-28
        • Neil Hodgson
          Neil Hodgson
          2013-05-28

          It matters to me because it is my time that is being used. I'm not seeing sufficient reason to perform any extra work on this issue.

          The performance degradation took somewhere between 1 and 5 weeks for you to notice so can't be all that significant.

           
          • kudah
            kudah
            2013-05-28

            The performance degradation took somewhere between 1 and 5 weeks for you to notice so can't be all that significant.

            As I've said, it causes a full redraw on almost every input, that's as much performance impact as a lexer can have, aside of looping forever.

            It matters to me because it is my time that is being used. I'm not seeing sufficient reason to perform any extra work on this issue.

            You're being too dramatic over a one line change. Merge whenever, I see no benefit in further discussion.

             
            Last edit: kudah 2013-05-28
  • Neil Hodgson
    Neil Hodgson
    2013-06-05

    Committed as [17d451].

     

    Related

    Commit: [17d451]

  • kudah
    kudah
    2013-07-01

    ‌‌

     
    • Neil Hodgson
      Neil Hodgson
      2013-07-03

      Committed as [e7960a].

       

      Related

      Commit: [e7960a]

  • Neil Hodgson
    Neil Hodgson
    2013-07-03

    • labels: patch --> patch, scintilla, lexer
    • status: open --> open-fixed
     
  • Neil Hodgson
    Neil Hodgson
    2013-07-21

    • status: open-fixed --> closed-fixed
     
<< < 1 .. 6 7 8 (Page 8 of 8)