#1459 Improvements to Haskell Lexer

Bug
closed-fixed
Neil Hodgson
3
2013-07-21
2013-04-03
kudah
No
  • Added support for MagicHash extension (lexer.haskell.allow.hash)
  • $ and # are now colored as operators.
  • .0 and -0 are now properly colored as operator and a number, not as just number.
  • Operators starting with double dash (e.g ---->) are properly colored as operators, not comments.
  • Added pragma highlighting.
  • Added basic C-preprocessor highlighting.
  • Qualified names (e.g. ABC.xyz) are now properly highlighted as identifiers, not types.
  • Qualified operators (e.g. ABC.<$>) are now properly highlighted as operators.
  • Operator . is now properly highlighted as an operator, not part of the identifier, when applied to a qualified and an unqualified value (e.g. Abc.xyz.yzx <- last one is an operator)
  • Operators starting with ':' are now properly highlighted as type constructors, not operators.
  • "family" after "data" is highlighted, as per TypeFamilies.
1 Attachments

Discussion

<< < 1 .. 5 6 7 8 > >> (Page 7 of 8)
  • kudah
    kudah
    2013-05-15

    3.3.2 will be early next week so any bugs/fixes should be uploaded soon.
    This tracker item is long which makes tracing history more difficult. New features should go into additional tracker items.

    I take it that I should post any remaining fixes to this bug, but file any new features to a new ticket?

     
    • Neil Hodgson
      Neil Hodgson
      2013-05-15

      Yes, please.

       
  • kudah
    kudah
    2013-05-18

    Fixed import folding in literate haskell.

     
    • Neil Hodgson
      Neil Hodgson
      2013-05-18

      Is this a bug fix or a new feature? Scintilla is in feature-freeze for 3.3.2. fold.haskell.imports.indented looks like a new feature. If its a bug, should I revert back to the 3.3.1 version of LexHaskell?

       
      • kudah
        kudah
        2013-05-18

        Is this a bug fix or a new feature?

        A minor fix.

        fold.haskell.imports.indented looks like a new feature.

        My working tree was inconsistent.

         
        • Neil Hodgson
          Neil Hodgson
          2013-05-19

          Committed as [e5cb15].

           

          Related

          Commit: [e5cb15]

  • kudah
    kudah
    2013-05-27

    • Removed extraneous LineState write which caused serious performance issues.
    • Fixed incoherent CPP highlighting with styling.within.preprocessor.
     
    • kudah
      kudah
      2013-05-27

      Can you close the ticket after this is merged?

       
      • Neil Hodgson
        Neil Hodgson
        2013-05-28

        There's a bug fix release 3.3.3 scheduled for June 2 so this won't be merged until then.

         
<< < 1 .. 5 6 7 8 > >> (Page 7 of 8)