#1115 [SciTEGTK.cxx] Fix pb on buffers.zorder.switching

Feature_Request
closed-fixed
Neil Hodgson
SciTE (622)
5
2014-08-19
2011-03-20
Jérôme LAFORGE
No

Hello Neil,
I propose you this patch for fixing pb with buffers.zorder.switching that doesn't work on GTK.

Jérôme

Discussion

  • patch #0

     
    Attachments
  • Neil Hodgson
    Neil Hodgson
    2011-03-21

    This feature is trying to emulate Windows Alt+Tab behaviour.

    The particular magic of zorder switching is that it is only when the Ctrl key is let up is the the choice made: every switch before this is just a proposal. This allows you to, for example, starting from Tab 1 Ctrl+Tab as many times as required to move to your destination (call it Tab D). Then a single Ctrl+Tab moves back to Tab 1: all the intermediate switches between Tab 1 and D are ignored.

    This is implemented in EndStackedTabbing and related code.

     
  • Neil Hodgson
    Neil Hodgson
    2011-03-21

    • assigned_to: nobody --> nyamatongwe
    • milestone: --> Feature_Request
     
  • Ok, thx for the information.
    I am newbie with GTK. So this patch can not have very good quality.
    Do you think that patch is correct?

     
  • Patch #1

     
    Attachments
  • Neil Hodgson
    Neil Hodgson
    2011-03-21

    Its only part of the job and doesn't provide the same functionality as on Windows. To be integrated it should work the same as on Windows.

    Another piece of code that has to be changed in the patch is to stop the default GTK+ processing of these keys in SciTEGTK::Key with the g_signal_stop_emission_by_name call.

     
  • Neil Hodgson
    Neil Hodgson
    2011-03-22

    Unlike Windows, it only recognizes releasing the left Ctrl key, not the right.

     
  • File #2

     
    Attachments
  • Please find the new file.
    Jérôme

     
  • Neil Hodgson
    Neil Hodgson
    2011-03-24

    • status: open --> open-fixed
     
  • Neil Hodgson
    Neil Hodgson
    2011-03-24

    Committed.

     
  • Thx.

     
    • status: open-fixed --> closed-fixed