#1080 Right-click doesn't cancel autocompletion

Bug
closed-fixed
Neil Hodgson
Scintilla (788)
5
2011-02-03
2010-12-25
Jordan Russell
No

Right-clicking causes the caret to move (possibly to a different line), so it should cancel autocompletion mode.

Patch attached.

Discussion

  • Neil Hodgson
    Neil Hodgson
    2010-12-29

    Shouldn't that be inside the test? Performing a copy of the selection doesn't need to cancel autocompletion.

     
  • Neil Hodgson
    Neil Hodgson
    2010-12-29

    • assigned_to: nobody --> nyamatongwe
    • status: open --> open-accepted
     
  • Jordan Russell
    Jordan Russell
    2011-01-01

    Yes, I suppose so.

    I've also spotted another minor issue: it doesn't take the focus when the right button goes down.

    Revised patch attached.

     
  • Neil Hodgson
    Neil Hodgson
    2011-01-03

    • status: open-accepted --> open-fixed
     
  • Neil Hodgson
    Neil Hodgson
    2011-01-03

    Committed.

     
  • This patch only touches ScintillaWin.cxx and not ScintillaGTK.cxx :'(
    Please, could we also have a fix for ScintillaGTK.cxx?
    Many thx

     
  • Neil Hodgson
    Neil Hodgson
    2011-02-03

    • status: open-fixed --> closed-fixed