From: Pascal G. <pas...@fr...> - 2009-10-31 08:05:10
|
[Fulvio, I copy Scid users list to see if others agree with our point of view] 2009/10/27 Fulvio <fb...@li...> > Pascal Georges wrote: > >> One other comment : in a previous patch, there was some code to handle >> the case where a move is entered and if already existing in a >> variation, this variation was entered in. >> Do you plan to send this as a separate patch ? >> >> Pascal >> >> >> > Yes, the code is really simple (i have attached the patch for main.tcl) and > i'm using it without problems. > My doubts are: > - Adding an option is the best way? Having multiple variations starting > with the same move creates, in my opinion, a really confusing game. Further, > even without adding an option, if one really wish can still add manually a > new variation with the menu. > That's right, and that is also my point of view about confusing games. But I see an issue here : if a move already exists in several variations, the first encountered is entered into. Maybe in that case it would be better to fallback to the display of the variation window (or something like that) to make sure the user will not enter a specific line when he wanted to enter another one. So what others think about this : when the user enters a move, if the move already exists in the main line or in a variation, the move is not duplicated but we simply move forward (no need to display the dialog box asking for adding a variation, a main line, etc.) ? Personaly I find it the best thing to do. > - The addSanMove proc is used only by the tree window. In my opinion, to > avoid the duplication of code, the best thing is to translate the move and > then call addMove. But i still haven't found an easy way to do it. > If your question is how to translate moves it is easily done with ::trans and ::untrans calls (defined in language.tcl). Pascal |