From: Ryan Culpepper <ryanc@cc...> - 2007-08-16 21:52:14
On Aug 16, 2007, at 3:48 PM, Eric Hanchrow wrote:
> Here's a problem which I've already solved, but I'm not in love with
> the solution, and am wondering if there's a better way.
> I have some functions that create threads, and sometimes those threads
> raise uncaught exceptions. And sometimes, alas, my tests don't notice
> (because the dead thread didn't directly contribute to the result my
> tests are looking for). And sometimes I don't notice the exception,
> since its only evidence is a few lines of output, which tend to get
> lost amongst all the other output.
> So I'd like a way for the tests to fail when a child thread raises an
> uncaught exception. Attached is the way I've found to do it, but it
> just seems clunky. Can someone suggest a better way?
I would combine the check of the result with the check that no child
thread threw an exception into one test, because they are part of the
same overall computation. As a rule, I try to keep my test cases
totally independent. In your example, the execution of the second test
depends on the state left by the first test.
Here's a procedure that might help. It's similar to your code, but it's
designed to be used locally within a test-case. It also checks that any
auxiliary threads are no longer running when the main computation
finishes. You may have to customize it to get what you want.
;; check-threads : (-> any) -> any
;; Runs thunk; raises error if any subthreads created by thunk raise
;; errors, or if a subthread outlives thunk's computation.
(define (check-threads thunk)
(let* ([main-cust (current-custodian)]
[sub-cust (make-custodian main-cust)]
(parameterize ((current-custodian sub-cust)
(set! sub-exns (cons exn sub-exns))
(let ([result (thunk)])
;; Check that sub-custodian has no living threads.
(filter thread? (custodian-managed-list sub-cust
(when (pair? sub-exns)
(error 'nice-threads "child thread raised exception"))
(error 'nice-threads "child thread left still running"))
;; error: child thread left still running
(thread (lambda () (sleep 1) 17))
;; error: child thread raised exception
(thread (lambda () (error "whoops")))
(let ([t (thread (lambda () (sleep 1) 17))])
> A bad analogy is like a leaky screwdriver.
> -- Richard Braakman
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems? Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >>
> Schematics-development mailing list
From: Eric Hanchrow <offby1@bl...> - 2007-08-16 22:30:27
Mm, food for thought, thanks!
(And I'd wondered if this mailing list was even alive; I guess it is :-)
When I just need to kick back after a long day of changing 1.s
into 0.s and 0.s into 1.s, nothing satisfies my primal fish urge
better than a can of Genova [tuna].
-- Ben Collins-Sussman