Menu

#197 Inactive cloud options partly visible

2.6.1
closed
nobody
None
5
2016-12-08
2015-10-16
No

The cloud properties for similarity are not active for Ertl and Wordle, and the labels are not
visible, however the checkboxes are visible and the tooltips work.

Discussion

  • Till Schäfer

    Till Schäfer - 2015-10-19

    Here it looks alright, with greyed out labels. Does it look different on Wndows? Can you maybe provide a screenshot?

    Tooltips are also showing, whicht should be disabled.

     
  • Karsten Klein

    Karsten Klein - 2015-10-19

    It does look different...!

     
  • Sven Schrinner

    Sven Schrinner - 2015-12-17

    The property labels not showing seems to be a weird Windows bug. Though the list is built and revalidated, the labels won't show until the user checks one. This only occurs, if no element is selected. Still searching for a proper way to fix that.

    Apart from this, the visibility looks as intended. The checkboxes and the labels are grayed out, as well as the buttons. I think a completely white list would not look very nice.

     
  • Sven Schrinner

    Sven Schrinner - 2015-12-17
    • status: open --> in-progress
    • Related To: -->
     
  • Sven Schrinner

    Sven Schrinner - 2015-12-18
    • status: in-progress --> open
     
  • Sven Schrinner

    Sven Schrinner - 2016-02-22

    What is actually left to do here? The only downside I see is, that the property list is not properly rendered after initializing the view. As mentioned, this is Windows specific and I don't know if we are actually able to fix this.

     
  • Till Schäfer

    Till Schäfer - 2016-03-07

    Is it possible to provide some workaround like checking and unchecking a checkbox (or vice versa) after initialization, calling invalidate after some period again, or something like that? Does unchecking all boxes also trigger this bug or is this realy limited to initialization?

     
  • Sven Schrinner

    Sven Schrinner - 2016-03-16

    I spent some time on this bug beforehand and I think the problem was, that the list is not revalidated after the main window has been created. The list itself is built, when the view is created. At that time, any actions like checking and unchecking all or some items have no effect. When the window is created, you can check a single element on the list. This will cause the checked item and all items below to be displayed correctly. The items above are not. They will become visible when you click a second time (either unchecking the same item, or selecting any other). This behavior is always the same, not depending on whether the list is greyed out or not.

    If the list already contains at least one checked element, then everything works as intended - even if the entire list is greyed out. I actually created a workaround some time ago, which starts a progress worker to check and uncheck the first element after two seconds. I will commit it, as it should not hurt much (you can see the checkbox flashing, because I need 100ms between checking and unchecking, otherwise the workaround does not work).

    I have no idea, why the list behaves so strange. I can't see any logic behind it, maybe it is just a bug in java swing. I would suggest to not invest too much time into this bug any more.

     
  • Sven Schrinner

    Sven Schrinner - 2016-03-16
    • status: open --> needs-info
     
  • Till Schäfer

    Till Schäfer - 2016-03-22

    does an invalidate after 2 seconds also help?

    is there any more reliable way to detect that the main window is initialized that just waiting 2 seconds?
    -> if the initialization takes more than two seconds, the bug still appears
    -> if it takes less than two seconds, there is a glitch until the 2 seconds elapsed.
    maybe we can register ourself to some event.

    If the answer to the above question is no, commit the workaround please.

     
  • Sven Schrinner

    Sven Schrinner - 2016-03-25

    The views have no access to the main window, so they cannot register themselves to it. We would have to change the view interface and add a reference to their windows (or the view manager) in order to do that.

    Regarding the workaround: It should now refresh after 1, 3 and 6 seconds to make sure the labels are visible fast and the workaround also works for large/slow sessions. The graphical glitch is shown as shortly as possible (currently a 10ms time windows - if the box is checked and unchecked again immediately, then the validation does not work).

     
  • Till Schäfer

    Till Schäfer - 2016-03-29
    • status: needs-info --> needs-review
     
  • Till Schäfer

    Till Schäfer - 2016-03-29

    karsten, can you review this bug? I have no Windows machine at hand.

     

    Last edit: Till Schäfer 2016-04-14
  • Till Schäfer

    Till Schäfer - 2016-09-01
    • assigned_to: Sven Schrinner --> nobody
     
  • Karsten Klein

    Karsten Klein - 2016-12-06

    It looks fine for me now on the win10 machine.
    I think this can be closed now.

     
  • Karsten Klein

    Karsten Klein - 2016-12-06
    • status: needs-review --> closed
     
  • Till Schäfer

    Till Schäfer - 2016-12-08
    • Group: any future version --> 2.6.1
     

Log in to post a comment.