Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#2681 parseQUALIFIERDECLARATION does not require TYPE attribute

Code_Cleanup
closed-fixed
Dave Blaschke
jsr48-client
5
2013-12-13
2013-10-02
Dave Blaschke
No

The DOM parser's CIMXMLParseImpl.parseQUALIFIERDECLARATION method does not require the TYPE attribute where as the SAX parser does. The attribute is required be the DSP:

<!ELEMENT QUALIFIER.DECLARATION (SCOPE?, (VALUE | VALUE.ARRAY)?)>
<!ATTLIST QUALIFIER.DECLARATION
    %CIMName;
    %CIMType; #REQUIRED
    ISARRAY (true|false) #IMPLIED
    %ArraySize;
    %QualifierFlavor;
>
1 Attachments

Related

Bugs: #2699

Discussion

  • Dave Blaschke
    Dave Blaschke
    2013-10-02

    Patch sent for community review. During a 2 week period any exploiter may comment on the patch, request changes or turn it down completely (with good reason). For the time being the patch is part of the "Experimental" branch in CVS.

     
  • Dave Blaschke
    Dave Blaschke
    2013-10-02

    • status: open --> open-fixed
     
  • Dave Blaschke
    Dave Blaschke
    2013-10-02

    Without the fix, a NullPointerException occurs:

     java.lang.NullPointerException
       at org.sblim.cimclient.internal.cimxml.CIMXMLParserImpl.parseSingleValue(CIMXMLParserImpl.java:1430)
       at org.sblim.cimclient.internal.cimxml.CIMXMLParserImpl.parseSingleValue(CIMXMLParserImpl.java:1412)
       at org.sblim.cimclient.internal.cimxml.CIMXMLParserImpl.parseQUALIFIERDECLARATION(CIMXMLParserImpl.java:1533)
       at org.sblim.cimclient.internal.cimxml.CIMXMLParserImpl.parseIPARAMVALUE(CIMXMLParserImpl.java:2309)
       at org.sblim.cimclient.internal.cimxml.CIMXMLParserImpl.parseIMETHODCALL(CIMXMLParserImpl.java:2523)
       at org.sblim.cimclient.internal.cimxml.CIMXMLParserImpl.parseSIMPLEREQ(CIMXMLParserImpl.java:2405)
       at org.sblim.cimclient.internal.cimxml.CIMXMLParserImpl.parseMESSAGE(CIMXMLParserImpl.java:2210)
       at org.sblim.cimclient.internal.cimxml.CIMXMLParserImpl.parseCIM(CIMXMLParserImpl.java:173)
       at org.sblim.cimclient.internal.wbem.CloseableIteratorDOM.parse(CloseableIteratorDOM.java:162)
       at org.sblim.cimclient.internal.wbem.CloseableIteratorDOM.<init>(CloseableIteratorDOM.java:84)
       at org.sblim.cimclient.unittest.wbem.Common.parseWithDOM(Common.java:75)
    
     
  • Dave Blaschke
    Dave Blaschke
    2013-10-29

    • status: open-fixed --> pending-fixed
     
  • Dave Blaschke
    Dave Blaschke
    2013-10-29

    The community review is completed and we received no substantial criticism. Therefore the patch has been approved and merged into the "HEAD" branch. The next release will pick it up.

     
  • Dave Blaschke
    Dave Blaschke
    2013-12-13

    • status: pending-fixed --> closed-fixed
     
  • Dave Blaschke
    Dave Blaschke
    2013-12-13

    The patch was picked up by release 2.2.5 and will be closed.