Jingyi Hou <houjingyi@...> writes:
> This trivial patch contains two parts:
> 1) search_for_executable() in src/runtime/runtime.c fails to process last
> part of PATH if PATH does not end with `:'.
> 2) FIXME tweak in src/compiler/node.lisp so that BLOCK-DELETE-P is
> findable by grep for `def.*block-delete-p'. I came across this `FIXME' when
> trying to understand the IR1 phase of Python.
> I did regression test on my Ubuntu laptop `i386 GNU/Linux
> 3.2.0-23-generic-pae', the test result turns out to be same as the newest
> git version 18.104.22.168-808d810, which shouldn't be a big surprise, :-)
> This is my first patch to SBCL, so if anything went wrong, please let me
Great! Thank you for your contribution. I think to make it most
straightforward, I would prefer it as two patches, each doing one thing
(I know they are both fairly trivial, but even so). If you could
separate them out, you could also delete the whole of the comment (not
just the "FIXME" text) above the definition of block-delete-p, since
your patch fixes the whole issue.