#10 source code problems compiling with gcc/g++

closed
nobody
None
5
2012-08-31
2008-05-11
guyster
No

The file IccProfLib/IccTagProfSeqId.h does not contain a newline at the end of the file. Therefore the compiler did not compile the source.

The file IccProfLib/IccCmm.cpp contains a "goto" jump, violating an initialisation:

IccCmm.cpp: In member function 'virtual icStatusCMM CIccApplyMruCmm::Apply(icFloatNumber*, const icFloatNumber*, icUInt32Number)':
IccCmm.cpp:5570: error: jump to label 'next_k'
IccCmm.cpp:5534: error: from here
IccCmm.cpp:5562: error: crosses initialization of 'icFloatNumber* dest'

(I would suggest removing goto statements anyway. There is *always* a way around using gotos, and it's always beneficial for the code quality)

Platform: Linux (Ubuntu Hardy, i386 compatible, gcc/g++ 4.2

Discussion

  • Max Derhak
    Max Derhak
    2012-08-31

    • status: open --> closed