キーワードヘルプの処理簡素化

A free Japanese text editor for Windows

Brought to you by: aroka, ds14050, gentaro, kench-jp, and 5 others

#498 キーワードヘルプの処理簡素化

Milestone: None

Status: closed

Owner: nobody

Labels: None

memo:

GitHub Pull Request No:

GitHub Issue No:

Priority: 5

Updated: 2013-05-12

Created: 2013-05-06

Creator: Moca

Private: No

ちょっとだけ余分な処理を省きました。

1 Attachments

skrw_keep_keyhekp.patch

Discussion

Moca - 2013-05-12

[r3006]でコミットしました。

Related

Commit: [r3006]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Moca - 2013-05-12

status: open --> closed

Group: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

novice123 - 2013-05-12

pszWorkは、cmemCurTextのバッファへのポインタなので、正常に動作しないのではないかと思います。

trunkにフィードバックしようと思ったのですが、動作しなかったので原因を調査したところ
CMemory::SetString()のEmpty()でバッファがクリアされていました。

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Moca - 2013-05-12

直前の行なのに見落としていました。
__SetStringLength()にしてみました。

skrw_keep_keyhekp_rev2.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Moca - 2013-05-12

status: closed --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

novice123 - 2013-05-12

もし、CNativeW側で吸収するのであれば(元の2回コピーするのは冗長)、
新しいメモリ確保 -> コピー -> 古いメモリ破棄
が必要と思ったのですが、切り詰めるだけであれば不要ですね。

パッチ適用でキーワードヘルプが表示されることを確認しました。

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Moca - 2013-05-12

[r3011]でコミットしました。

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Moca - 2013-05-12

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.