Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#3 Safecopy copies blocks not specified in include file

closed-fixed
Eric Price
8
2010-09-19
2009-09-08
Eric Price
No

When marking badblocks in the destination is enabled, safecopy reads the next block number from the include file to see where it is allowed to write.
This leads to a situation where safecopy treats all blocks between the last attempted read block and the next include block as include blocks, too, even while they are not.

Reproduction:

an include file with two sets of blocks.
badblock marking enabled.
the last block of the first set of include blocks fails to read, getting marked as bad.

Expected result:
bad block gets marked, then safecopy skips to the first block in the second group of include blocks and continues there.

Actual result:
bad block gets marked, then safecopy copies ALL the blocks towards and including the second group of include blocks!

This bug will be permanently fixed in safecopy 1.6

a hotfix patch will be provided beforehand asap.

Discussion

  • Eric Price
    Eric Price
    2009-09-08

    • status: open --> open-accepted
     
  • Eric Price
    Eric Price
    2009-09-09

    patch to fix bad block include file handling

     
  • Eric Price
    Eric Price
    2009-09-09

    • status: open-accepted --> open-fixed
     
  • Eric Price
    Eric Price
    2009-09-09

    Fixed the bug with release 1.6
    Leaving the bug open in case of additional problems arising with the fix...

     
  • Eric Price
    Eric Price
    2010-09-19

    • status: open-fixed --> closed-fixed
     
  • Eric Price
    Eric Price
    2010-09-19

    no more issues found so far - closing