From: Masao M. <mu...@hi...> - 2003-08-02 04:31:03
|
Hi, On Fri, 1 Aug 2003 20:36:25 +0200 Martin Povoln$(D+r(B <xpo...@au...> wrote: > Hallo, > > I've done most changes, you suggested. Could you please take a look? > I think gtkhtml2 would be a nice extension to ruby-gnome2 ;-) > The tgz file needs to be unpacked in ruby-gnome2 root. It also contains > a simple test/example. Good job;) I have some suggestions: * I hope to change the module name. I prefer Gtk::HtmlView, Gtk::HtmlDocument to GtkHtml2::HtmlView, GtkHtml2::HtmlDocument Because "Html" overlaped and "2" will occur some problems. * It seems you don't need to define rb_html_document_link_clicked_sigf and G_DEF_SIGNAL_FUNC for "link_clicked". * You shouldn't include global.h of Ruby/GTK. * Define arguments of Init_* like as: void Init_html_view(mGtkHtml2) VALUE mGtkHtml2; <- Here! { #I don't know how can I say this definition in English:-<. * Put README/ChangeLog to gtkhtml2/ like other libraries. * Put test.rb to gtkhtml2/samples like other libraries. -------------- Then, I have to ask you some questions as you know. # Should I make a template of this? 1. Where do you put it in CVS? Ruby-GNOME2 CVS policy is: a. [SourceForge]/ruby-gnome2/ruby-gnome2/xxxxx The core gnome2 libs. The libs under ruby-gnome2 release together. The version numbers are unified. You can't release xxxxx only. b. [SourceForge]/ruby-gnome2/xxxxx The libs are released themselves. The version numbers are not unified ruby-gnome2 libs. You can release only xxxxx when you need. Please take care this choice;). 2. Do you hope to release it as separate package like as ruby-gtk/ruby-gstreamer? 3. Tell me your CVS account of SF. Thanks in advance, Masao. -- .:% Masao Mutoh<mu...@hi...> |