From: Martin <cinekcvs@gm...> - 2004-04-28 20:52:04
I am reviewing the code, e.a.:
- fixing minor things to make the code look better
- checking docs
- checking line breaks and indentation
I noticed few things. First of all, I like the code.
There are many interesting implementations, which really
impress me. I'm somehow proud of our project. It can serve
as an example for other people.
Secondly, I have also a few minor issues, which I want
to report so far.
- I have found places where one of our classes was
constructed with a default constructor and then a few
setters have been called. In this specific case there
was another constructor which could be called with exactly
same parameters that the setters influenced. Please try
to avoid such thing, because extending the application
will get more difficult this way. Sometimes it would be
a good idea to make new constructors, if you use setters
right after object creation. Please also look how default
values (e.g. "null") are being treated inside the constructors
and setters to avoid code duplication.
- I would like to know who made this great JSortableTable.
This is a cool piece of code. But please fix the copyright
notice. My name does not belong there!
I cannot wait until the next release. We have one bug left.
Christoph wants to fix it. I will continue my code reviews
for now. You can of course help me, if you have time.