#88 wallpaper: tolerate directories in image directories

open
nobody
None
5
2005-03-28
2005-03-28
The Anarcat
No

My "Scaled", "Stretched", etc directories are CVS
checkouts. When Wallpaper runs long enough, it hits
this directory and crashes. I have to restart it to
ever have a background again...

This patches makes Wallpaper ignore directories in its
image directories. A better fix would be to recurse,
but this has other implications and just skipping
directories Just Works For Me. :)

Enjoy!

A.

Discussion

  • The Anarcat
    The Anarcat
    2005-03-28

     
    Attachments
  • The Anarcat
    The Anarcat
    2005-03-28

    Logged In: YES
    user_id=246797

    Err... I just noticed I already submitted this bug. :( Thing
    is I just switched to zero-install, and the version over
    there doesn't have the fix:

    $ grep -4 os.listdir
    /uri/0install/rox.sourceforge.net/apps/Wallpaper/latest/actions.py
    def images(path, style):
    if not path:
    return []
    ret = []
    for file in os.listdir(path):
    ret.append((os.path.join(path,
    file), style))
    return ret

    images = images(choices.load('Wallpaper',
    'Centred'), 'centre') + \

    ... The fix committed on actions.py rev. 1.10 some 16 months
    ago didn't seem to propagate to 0install.

    If it's something I'm missing, I apologize in advance...