From: Barry K. <bk...@go...> - 2006-12-26 23:08:54
|
Using Filer 2.5. I already posted a few weeks ago about a scaling bug -- for large-thumbnails selection, small images are scaled up -- Puppy Linux has a heap of 16x16 xpm's and they all get scaled up and look really crappy. Another bug related to thumbnails. This one got reported to me, as we are testing Puppy 2.13BETA with Filer 2.5 in it. Open ROX-Filer on the /proc directory, Rox freezes and have to restart X. Turn off thumbnails, Rox does not freeze. Look in /sys, no problem. Both of those bugs I would say are serious, but I was very surprised to find both of them in ROX-Filer 2.4.1. I want to bring out Puppy 2.13-final soon, so I thought I would test older versions of Rox. So, I went back further, tried Rox 2.2.0. This renders thumbnails perfectly, and just as fast it seems as the latest Rox. Even faster -- or perhaps I got that impression as a folder full of 16x16 images were rendered as-is, not scaled up. Unfortunately, v2.2.0 has a display bug, choosing "Show extra details" crashes Rox -- from the changelog it seems that this is a problem with GTK versions >2.8.9 (Puppy has 2.8.17). I was feeling rather frustrated by then! I thought, a version of Rox with the thumbnail rendering of v2.2.0 and the display-switching bugfix of v2.4.1 would be ideal! -- but I don't think there is any intermediate release like that. So, I would like to request, pretty please, the next Rox, 2.5.1, could it please have the two above-mentioned bugs fixed? We love ROX-Filer in the Puppy-world. The old 1.2.2 has been a main-stay for years, rock solid. Regards, Barry Kauler www.puppyos.com |
From: Thomas L. <ta...@gm...> - 2006-12-27 12:43:59
|
On 12/26/06, Barry Kauler <bk...@go...> wrote: > Using Filer 2.5. I already posted a few weeks ago about a scaling bug -- > for large-thumbnails selection, small images are scaled up -- Puppy > Linux has a heap of 16x16 xpm's and they all get scaled up and look > really crappy. Did reversing the changes to pixmaps.c from changeset r3715:3716 not fix it? (i.e. using gdk_pixbuf_new_from_file instead of rox_pixbuf_new_from_file_at_scale) > Another bug related to thumbnails. This one got reported to me, as we > are testing Puppy 2.13BETA with Filer 2.5 in it. Open ROX-Filer on the > /proc directory, Rox freezes and have to restart X. Turn off thumbnails, > Rox does not freeze. Look in /sys, no problem. Works fine here. Any idea what it's doing? (try 'strace -p ...' from a console) > Both of those bugs I would say are serious, but I was very surprised > to find both of them in ROX-Filer 2.4.1. > I want to bring out Puppy 2.13-final soon, so I thought I would test > older versions of Rox. > > So, I went back further, tried Rox 2.2.0. This renders thumbnails > perfectly, and just as fast it seems as the latest Rox. Even faster > -- or perhaps I got that impression as a folder full of 16x16 images > were rendered as-is, not scaled up. > Unfortunately, v2.2.0 has a display bug, choosing "Show extra details" > crashes Rox -- from the changelog it seems that this is a problem with > GTK versions >2.8.9 (Puppy has 2.8.17). The fix is in r4262. You can get the patch with: svn diff -r4261:4262 https://rox.svn.sourceforge.net/svnroot/rox/trunk/rox/ROX-Filer Although, I'd rather find out why the new version doesn't work! -- Dr Thomas Leonard http://rox.sourceforge.net GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Barry K. <bk...@go...> - 2006-12-28 12:27:24
|
Thomas Leonard wrote: > On 12/26/06, Barry Kauler <bk...@go...> wrote: >> Using Filer 2.5. I already posted a few weeks ago about a scaling bug -- >> for large-thumbnails selection, small images are scaled up -- Puppy >> Linux has a heap of 16x16 xpm's and they all get scaled up and look >> really crappy. > > Did reversing the changes to pixmaps.c from changeset r3715:3716 not fix it? > > (i.e. using gdk_pixbuf_new_from_file instead of > rox_pixbuf_new_from_file_at_scale) > >> Another bug related to thumbnails. This one got reported to me, as we >> are testing Puppy 2.13BETA with Filer 2.5 in it. Open ROX-Filer on the >> /proc directory, Rox freezes and have to restart X. Turn off thumbnails, >> Rox does not freeze. Look in /sys, no problem. > > Works fine here. Any idea what it's doing? > > (try 'strace -p ...' from a console) > >> Both of those bugs I would say are serious, but I was very surprised >> to find both of them in ROX-Filer 2.4.1. >> I want to bring out Puppy 2.13-final soon, so I thought I would test >> older versions of Rox. >> >> So, I went back further, tried Rox 2.2.0. This renders thumbnails >> perfectly, and just as fast it seems as the latest Rox. Even faster >> -- or perhaps I got that impression as a folder full of 16x16 images >> were rendered as-is, not scaled up. >> Unfortunately, v2.2.0 has a display bug, choosing "Show extra details" >> crashes Rox -- from the changelog it seems that this is a problem with >> GTK versions >2.8.9 (Puppy has 2.8.17). > > The fix is in r4262. You can get the patch with: > > svn diff -r4261:4262 > https://rox.svn.sourceforge.net/svnroot/rox/trunk/rox/ROX-Filer > > Although, I'd rather find out why the new version doesn't work! > > I'm just using the official 2.5 release, haven't looked into any fixes for the thumbnail scaling. One of our Puppy detectives has figured out why ROX-Filer is freezing on /proc. His post is a comment in my Puppy Developer News blog: http://www.puppyos.net/blog/comments.php?y=06&m=12&entry=entry061228-010258 ...that seems to identify the cause, but how to fix it? Regarding patching v2.2.0, I would rather not. It would be better if we kept up with you guys, using the latest version. Regards, Barry Kauler |
From: Thomas L. <ta...@gm...> - 2006-12-28 15:10:55
|
On 12/28/06, Barry Kauler <bk...@go...> wrote: [...] > One of our Puppy detectives has figured out why ROX-Filer is freezing > on /proc. His post is a comment in my Puppy Developer News blog: > http://www.puppyos.net/blog/comments.php?y=06&m=12&entry=entry061228-010258 > > ...that seems to identify the cause, but how to fix it? I'm surprised ROX-Filer has permission to read /proc/kmsg. Here only root can open it. An easy solution is not to bother trying to thumbnail zero-byte files (since they're either empty or special). I've committed a possible fix as revision 4888. Thanks, -- Dr Thomas Leonard http://rox.sourceforge.net GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |