From: Tom Breton (Tehom) <tehom@pa...> - 2012-04-04 19:57:57
Are we feature-frozen at the moment? If not, I'd like to push a
change to how we find the default key for the key signature dialog.
Basically instead of using GuessKey to guess it from notes, I take the
most common key signature currently in effect in the other segments. If
there's none I fall back to guessKey.
The new function is AnalysisHelper::guessKeyAtTime. I call it in
NotationView and MatrixView.
I had first tried changing guessKey itself to the Krumhansl and
Kessler approach of keyfinding, but that made no difference so I
Tom Breton (Tehom)
From: D. Michael McIntyre <michael.mcintyre@ro...> - 2012-04-05 09:48:03
On Wednesday, April 04, 2012, Tom Breton (Tehom) wrote:
> Are we feature-frozen at the moment? If not, I'd like to push a
> change to how we find the default key for the key signature dialog.
If it doesn't change any user-visible strings, go ahead. It sounds like a
D. Michael McIntyre