From: Tom Breton (Tehom) <tehom@pa...> - 2011-10-05 22:11:21
I'd like to make the velocity dialog smarter. For instance, when you make
a crescendo, the start velocity would default to the lowest velocity among
the selected events and the end velocity to the highest.
But the way EventParameterDialog works makes it difficult to do so. It
doesn't see the selection. Right now it couldn't because it's trying to
be a general note-property editor too. AFAICT it's not used for anything
but velocity now and my change would actually make other uses somewhat
So I'm asking, is anybody attached to the way it works now?
What I'd like to do is factor out the velocity smarts into a helper class.
That class would know the selection and other info. EventParameterDialog
would just know the widgets, and would get text etc from the helper class.
The two existing callers of EventParameterDialog would create that class,
pass it to EventParameterDialog, and when done, pass it to
SelectionPropertyCommand (which is used just for this and two lighter
velocity commands. I'd adapt all four callers).
Having done that, then I could make the dialog get smarter initial values,
Tom Breton (Tehom)
From: D. Michael McIntyre <michael.mcintyre@ro...> - 2011-10-05 22:39:29
On Wednesday, October 05, 2011, Tom Breton (Tehom) wrote:
> So I'm asking, is anybody attached to the way it works now?
It's a very good habit to ask questions like this up front, because this
project does have more than its fair share of people who get attached to the
stupidest little things. I'm probably the worst for this.
In this case, I barely remember anything about the dialog in question. It
looks like Chris wrote it quite a long time ago, and it has basically remained
unchanged since then.
I call that fair game, Tom. Your plan sounds reasonable enough to me, and if
anyone does end up taking exception to all this, it's on my head and not
D. Michael McIntyre