From: D. M. M. <ros...@gm...> - 2014-09-23 01:15:10
|
On 09/22/2014 08:07 PM, Chris Pardy wrote: > I'm not sure if there's too much to be gained by this additional level > of abstraction but it seemed like an elegant solution. (And it works.) All of that sounds great to me. > I'm using git-svn and made this patch with git diff --no-prefix. Please > let me know if you would prefer a different format. That should be fine. I'll be happy to look it over. (It sounds like you think there was a patch attached to your message. There was not.) > There's a few other issues I have noticed that I am having a look at. > and disables itself based on the selection from the Lilypond version > combo box. I think I'll check to see it any other options are version > dependent and change those as well. That's an excellent idea! > I've also noticed that something weird is happening when trying to enter > triplets in notation view, but I think this will be more complex to fix > because it works intermittently. Our notation editor is notoriously fiddly, but it's usually possible to achieve the desired results one way or another. Whenever it isn't, that's interesting. Anything relating to triplets should consider Tom Breton's gigantic tuplet rewrite branch, which has involved hundreds of commits, and should merge eventually. His work changes the entire game. Welcome aboard! I wish I had more to offer. -- D. Michael McIntyre |