Menu
▾
▴
[Rhq-commits] [rhq-project.org rhq] [1882] add better debug logging around OOB processing so that it's easier to gather point-in-time information that becomes obsolete after each auto-baseline-calculation job;
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><style type="text/css"><!-- #msg DL { border : 1px #006 solid; background-color : #369; padding : 6px; color : #fff; } #msg DT { float : left; width : 6em; font-weight : bold; } #msg DL, #msg DT, #msg UL, #msg LI { font-family : arial,helvetica,sans-serif; font-size : 10pt; } h3 { font-family : arial,helvetica,sans-serif; font-size : 10pt; font-weight : bold; } #msg PRE { overflow : auto; white-space : normal; background-color : #ffc; border : 1px #fc0 solid; padding : 6px; } #msg UL, PRE, .diff { overflow : auto; } #patch h4 { font-family : arial,helvetica,sans-serif; font-size : 10pt; } #patch h4 { padding: 8px; background : #369; color : #fff; margin : 0; } #patch .propset h4, #patch .binary h4 {margin: 0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {background:#eeeeee;padding: 0 0 10px 0;} #patch .propset .diff, #patch .binary .diff {padding: 10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch .add {background:#ddffdd;} #patch .rem {background:#ffdddd;} #patch .lines, .info {color:#888888;background:#ffffff;} .diff { width : 100%; } #msg DL { border : 1px #006 solid; background-color : #369; padding : 6px; color : #fff; } #msg DT { float : left; width : 6em; font-weight : bold; } #msg DL, #msg DT, #msg UL, #msg LI { font-family : arial,helvetica,sans-serif; font-size : 10pt; } h3 { font-family : arial,helvetica,sans-serif; font-size : 10pt; font-weight : bold; } #msg PRE { overflow : auto; white-space : normal; background-color : #ffc; border : 1px #fc0 solid; padding : 6px; } #msg UL, PRE, .diff { overflow : auto; } #patch h4 { font-family : arial,helvetica,sans-serif; font-size : 10pt; } #patch h4 { padding: 8px; background : #369; color : #fff; margin : 0; } #patch .propset h4, #patch .binary h4 {margin: 0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {background:#eeeeee;padding: 0 0 10px 0;} #patch .propset .diff, #patch .binary .diff {padding: 10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch .add {background:#ddffdd;} #patch .rem {background:#ffdddd;} #patch .lines, .info {color:#888888;background:#ffffff;} .diff { width : 100%; } --></style> <title>[rhq-project.org rhq] [1882] add better debug logging around OOB processing so that it's easier to gather point-in-time information that becomes obsolete after each auto-baseline-calculation job; </title> </head> <body> <div id="msg"> <dl> <dt>Revision</dt> <dd>1882</dd> <dt>Author</dt> <dd>jmarques</dd> <dt>Date</dt> <dd>2008-11-04 17:49:11 -0600 (Tue, 04 Nov 2008)</dd> </dl> <h3>Log Message</h3> <pre>add better debug logging around OOB processing so that it's easier to gather point-in-time information that becomes obsolete after each auto-baseline-calculation job; </pre> <h3>Modified Paths</h3> <ul> <li><a href="#rhqtrunkmodulesenterpriseserverjarsrcmainjavaorgrhqenterpriseserveralertengineAlertConditionCachejava">rhq/trunk/modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/engine/AlertConditionCache.java</a></li> </ul> </div> <div id="patch"> <h3>Diff</h3> <a id="rhqtrunkmodulesenterpriseserverjarsrcmainjavaorgrhqenterpriseserveralertengineAlertConditionCachejava"></a> <div class="modfile"><h4>Modified: rhq/trunk/modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/engine/AlertConditionCache.java (1881 => 1882)</h4> <pre class="diff"> <span class="info">--- rhq/trunk/modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/engine/AlertConditionCache.java 2008-11-04 23:44:25 UTC (rev 1881) +++ rhq/trunk/modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/alert/engine/AlertConditionCache.java 2008-11-04 23:49:11 UTC (rev 1882) </span><span class="lines">@@ -611,11 +611,21 @@ </span><span class="cx"> try { if (OutOfBoundsCacheElement.class.isInstance(cacheElement)) { // don't bother with active property for OutOfBoundsCacheElement types </span><span class="rem">- double diff = ((Double) providedValue).doubleValue() - - ((Double) cacheElement.getAlertConditionValue()).doubleValue(); </span><span class="add">+ double providedDoubleValue = ((Double) providedValue).doubleValue(); + double cacheElementDoubleValue = ((Double) cacheElement.getAlertConditionValue()).doubleValue(); + double diff = providedDoubleValue - cacheElementDoubleValue; </span><span class="cx"> cachedConditionProducer.sendOutOfBoundsConditionMessage(cacheElement .getAlertConditionTriggerId(), Double.valueOf(diff), timestamp); </span><span class="add">+ if (log.isDebugEnabled()) { + OutOfBoundsCacheElement oobCacheElement = ((OutOfBoundsCacheElement) cacheElement); + AlertConditionOperator operator = oobCacheElement.getAlertConditionOperator(); + String type = (operator == AlertConditionOperator.LESS_THAN) ? "LOW" : "HIGH"; + log.debug("OutOfBoundsCacheElement match: baselineId=" + + oobCacheElement.getAlertConditionTriggerId() + "type=" + type + ", providedValue=" + + providedDoubleValue + ", cacheElementValue=" + cacheElementDoubleValue + ", diff=" + + diff + ", timestamp=" + timestamp); + } </span><span class="cx"> } else { /* * Set the active property for alertCondition-based cache elements, and send it on its way; </span> </pre> </div> </div> </body> </html> |