Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#2 Bug 3170864 fix

open
nobody
None
5
2011-02-02
2011-02-02
Max Agapov
No

Proposed fix for incorrect (unencoded) display of non-ASCII names of attachments. The fix is to call already existing function rfc1522_decode_to_utf8() from type_desc(), which is defined in mimedesc.c and responsible for part description formatting.

Discussion

  • Max Agapov
    Max Agapov
    2011-02-02

    patch file generated using 'diff -u old_file new_file"

     
    Attachments
  • Thanks for this. Does this also take into account displaying the info on a non-utf8 capable terminal? Or will it just scramble things there?

     
  • Max Agapov
    Max Agapov
    2011-02-03

    > Thanks for this. Does this also take into account displaying the info on a
    > non-utf8 capable terminal? Or will it just scramble things there?

    There's nothing specific in the patch to handle that. However, it looks like Writewchar(UCS ucs), which paints the screen, handles conversion automatically. If it detects that terminal is not capable to display a character, then it will put question mark '?'.

     
  • Thank you for verifying that. I'll try to get this commited asap.

     
  • Commited to master.