#93 At some keymap, strtol is overflowed.

closed-accepted
None
5
2006-01-01
2005-11-26
Byeong-Sik, Jeon
No

At Korean keymap(keymaps/ko), "map 0xe0010412",
"g_keylayout = strtol(...)" is overflowed.

At Japanese keymap(keymaps/ja), "map 0xe0010411",
same above ....

"strtol" must to change "strtoul".

Discussion

    • assigned_to: nobody --> astrand
     
  • Logged In: YES
    user_id=335423

    Peter, the change looks sensible (though admitedly I don't
    have a Japanese Windows installation to test it with). Will
    you check it in?

     
  • Logged In: NO

    I've applied the changes to rdesktop.c, secure.c and
    xkeymap.c. However, I don't understand the motivation behind
    the changes to the "ko" and "ja" keymaps. Why are these
    necessary?

     
  • Logged In: YES
    user_id=1175121

    the changes of the "ko" and "ja" keymaps is not always
    necessary.
    and "strtol -> strtoul" change is not depends to keymap changes.

    but, I think that the changes are more general
    for the latest Windows Version(XP, 2003, and abobe ...) .

     
  • Logged In: YES
    user_id=1175121

    HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Keyboard
    Layouts\E0010412

    E0010412 is Korean Input System(IME 2000)
    E0010411 is Japanese Input System(MS-IME 2002)

    Chainese Input System(E0010404, E0010804, ....)

     
  • Peter Åstrand
    Peter Åstrand
    2005-12-31

    Logged In: YES
    user_id=344921

    >the changes of the "ko" and "ja" keymaps is not always
    >necessary.

    Please be more specific, why isn't the current layout code
    sufficient?

     
  • "map 0x412", "map 0xe0010412"

     
  • Logged In: YES
    user_id=1175121

    When I set "ko" keymaps with "map 0x412",
    If I execute "rdesktop -k ko 192.168.10.3",
    then I can't use "Korean/English input mode toggle key) and
    I can't input Korean character.
    I should be change to "Microsoft IME 2003" through mouse click.

    But, when I set "ko" keymap with "map 0xe0010412",
    It's all good.

    I found Japanese case recently.

    http://tdiary.flowernet.gr.jp/jado/?date=20051007

    It's all the same case.

    I attach image file.

    I don't know good 0x412 case.

     
  • Peter Åstrand
    Peter Åstrand
    2006-01-01

    • status: open --> closed-accepted
     
  • Peter Åstrand
    Peter Åstrand
    2006-01-01

    Logged In: YES
    user_id=344921

    Ok. I've applied this part of the patch as well. Thanks.
    Closing.