Menu ▾ ▴

#182 Full color mouse cursors

open
nobody
None
5
2012-11-29
2009-12-20
Michael Gilbert
No

Adding support for full color mouse cursors based on work done in artifact 2884937.

This patch requires libXcursor, which ships with recent versons of XFree86 and Xorg. In this context, the Xcursor library basically acts as a wrapper around around libXrender, falling back to Xlib calls if the RENDER extension is not available.

I think configure.ac should probably be changed to reflect the new dependency, but I have never done any work with autoconf.

Some of the code still feels "dirty" to me, especially the handling of the andmask bitfield. I also have no idea if this works for bpp values other than 1 and 32 since I can't figure out how to get the server to send anything else.

I will happily take any suggestions for cleaning things up.

Discussion

  • Michael Gilbert

    Michael Gilbert - 2009-12-20

    Color cursors patch

     
    xcursor.patch
  • Comment has been marked as spam. 
    Undo

    View and moderate all "patches Discussion" comments posted by this user

    Mark all as spam, and block user from posting to "Patches"

    Anonymous

    Anonymous - 2010-05-28

    root@template1:/.backup/rdesktop/rdesktop-1.6.0# patch -p1 < xcursor.patch
    patching file Makefile.in
    Hunk #1 succeeded at 39 (offset 4 lines).
    patching file xwin.c
    Hunk #2 FAILED at 2778.
    Hunk #3 FAILED at 2830.
    2 out of 3 hunks FAILED -- saving rejects to file xwin.c.rej