I am using Xorg version of X11.
When I tried rdesktop 1.5.0 on my PC that runs linux (FC5),
rdesktop crashes (SEGV in XputImage) every time
a certain GUI operation was done.
For example, when I try to open "Open File" menu of adobe
I tracked down the problem to an inconsistent calculation
of pad value that is passed to XCreateImage() that was
called before XPutImage(). XCreateImage() returned NULL image pointer,
and this caused the subsequent XPutImage() to crash.
With the attached patch, rdesktop runs fine now : at least, it doesn't
crash on my PC.
I think the use of 16 bit pixel value on my NDIVIA graphics chip
revealed the dormant problem.
The crash occurred irrespective of the
display setting on my ordinary windows desktop on real window PC.
(Oh, I forgot to check the command parameter to rdesktop, but
in any case, the calculation seems to be inconsistent and
incorret at worst.)
X Window System Version 7.0.0
Release Date: 21 December 2005
X Protocol Version 11, Revision 0, Release 7.0
Build Operating System:Linux 2.6.9-42.0.8.ELsmp i686Red Hat, Inc.
Current Operating System: Linux dell-w2k-note 2.6.20-1.2312.fc5 #1 Tue Apr 10 15:09:44 EDT 2007 i686
Build Date: 08 April 2007
(**) NVIDIA(0): Depth 16, (--) framebuffer bpp 16
(II) NVIDIA(0): Setting mode "1600x1200"