#105 Add _NET_WM_PID and WM_CLIENT_MACHINE window props

open
nobody
None
5
2006-03-01
2006-02-28
No

adds _NET_WM_PID and WM_CLIENT_MACHINE X properties to
the window.

This aids panels and window managers in actually
_finding_ the process that
displays a particular window.

Should have no side effects.

Discussion

  • Logged In: YES
    user_id=335423

    The idea of the patch is great and it's about time someone
    added it.

    Few comments:
    1. Why hostname[90]? Where's the 90 from? Why not HOST_NAME_MAX?
    2. This comment is unclear:

    + /* XSetWMProperties(g_dislpay, g_wnd, window_name, icon_name,
    + argv, argc, normal_hints, wm_hints, class_hints); also
    does the
    + XSetWMClientMachine bit too */

    3. In the error message, "Error: ..." should begin with a
    capital letter.
    4. No need for the 'pid' variable really. Just trying to
    reduce clutter.

     
    • summary: [PATCH] add hostname+pid to properties of window --> Add _NET_WM_PID and WM_CLIENT_MACHINE window props
     
  • Logged In: YES
    user_id=765110

    > 1. Why hostname[90]? Where's the 90 from? Why not
    HOST_NAME_MAX?

    random value from my magic hat? Using the HOST_NAME_MAX is
    better, yes :)

    > 2. This comment is unclear:
    +/* XSetWMProperties(g_dislpay, g_wnd, window_name,
    icon_name,
    + argv, argc, normal_hints, wm_hints, class_hints); also
    does the
    + XSetWMClientMachine bit too */

    This notes an alternative way of doing more things (window
    title, iconified title, hints *and* WM_MACHINE_NAME) in one
    function call (in case you want to coalesce it more). Can
    be removed :)

    > 3. In the error message, "Error: ..." should begin
    with a capital letter.

    No objections :)

    > 4. No need for the 'pid' variable really. Just trying
    to reduce clutter.

    Agreed

     
  • o1c7ay 1978505 90p47j [URL=http://reachingforlucidity.net/live/stellenangebote-berlin.php] stellenangebote berlin [/URL] <a href="http://reachingforlucidity.net/live/stellenangebote-berlin.php"> stellenangebote berlin </a> http://reachingforlucidity.net/live/stellenangebote-berlin.php

     
  • Maverick
    Maverick
    2011-11-22

    I've tried this patch with rdesktop 1.7.0 but wmctrl still doesn't show the rdesktop window :(