Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#101 Fix for multiple screens with different bpp

closed
None
5
2006-07-11
2006-01-28
Jeremy Smith
No

I ran into a problem where I was getting the following
error:

ERROR: The display does not support true colour - high
colour support unavailable.

...even though I'm at 16bpp and requested 8bpp.

It turns out the problem was related to the fact that I
have a video card with TV-out, which is my screen #1 @
24bpp, but I'm trying to run on my main CRT (screen #0
@ 16bpp). rdesktop forgets to set the screen number
before calling XGetVisualInfo which results in this error.

Attached is a tiny patch that references the screen
number when calling XGetVisualInfo and thus fixes the
issue ;)

Discussion

  • Jeremy Smith
    Jeremy Smith
    2006-01-28

    • summary: Fix for running on setup with multiple screens --> Fix for multiple screens with different bpp
     
  • Jeremy Smith
    Jeremy Smith
    2006-01-28

    Logged In: YES
    user_id=376474

    fixed patch typo

     
    • assigned_to: nobody --> astrand
     
  • Logged In: YES
    user_id=335423

    Thanks Jeremy.

    Peter, I tested this and it looks cool. I'll post an updated
    patch for this (current one has bitrot a bit following
    latest code changes) after we merge my fix to "Refactoring
    of color depth code".

     
  • Logged In: YES
    user_id=335423

    Peter, please check this updated patch in.

     
  • Logged In: YES
    user_id=335423

    Peter, will you check this in, or can I assign this to
    Pierre or someone else?

    Note: After fixing this, close bug 1417419.

     
  • Logged In: NO

    Applied.
    This could also help the people currently having problems
    with two monitors, xorg 7.0.22 and the nvidia-driver.

     
    • assigned_to: astrand --> stargo
    • status: open --> closed