From: Aaron L. <the...@gm...> - 2013-01-08 06:14:34
|
Hi, I run rdesktop with virtualbox's internal rdp server, so all connection are for localhost (I know I can use -T option, but .. ) But I still think showing the port number on title bar is reasonable... --- rdesktop-1.7.1/rdesktop.c 2013-01-07 17:43:13.710045134 +0800 +++ rdesktop-1.7.1.my/rdesktop.c 2013-01-07 17:43:26.996711845 +0800 @@ -967,8 +967,7 @@ if (g_title[0] == 0) { - strcpy(g_title, "rdesktop - "); - strncat(g_title, server, sizeof(g_title) - sizeof("rdesktop - ")); + snprintf(g_title, sizeof(g_title), "rdesktop - %s:%d", server, g_tcp_port_rdp); } #ifdef RDP2VNC What do you think? -- Best Regards, Aaron Lewis - PGP: 0xDFE6C29E ( http://keyserver.veridis.com ) Finger Print: 9482 448F C7C3 896C 1DFE 7DD3 2492 A7D0 DFE6 C29E |
From: Peter Å. <as...@ce...> - 2013-01-08 07:31:13
|
I think most "normal" users will think it's ugly to see :3389 all the time... Perhaps only show the port if not 3389? Rgds, Peter On Tue, 8 Jan 2013, Aaron Lewis wrote: > Hi, > > I run rdesktop with virtualbox's internal rdp server, so all > connection are for localhost > (I know I can use -T option, but .. ) > > But I still think showing the port number on title bar is reasonable... > > --- rdesktop-1.7.1/rdesktop.c 2013-01-07 17:43:13.710045134 +0800 > +++ rdesktop-1.7.1.my/rdesktop.c 2013-01-07 17:43:26.996711845 +0800 > @@ -967,8 +967,7 @@ > > if (g_title[0] == 0) > { > - strcpy(g_title, "rdesktop - "); > - strncat(g_title, server, sizeof(g_title) - sizeof("rdesktop - ")); > + snprintf(g_title, sizeof(g_title), "rdesktop - %s:%d", > server, g_tcp_port_rdp); > } > > #ifdef RDP2VNC > > What do you think? > > -- > Best Regards, > Aaron Lewis - PGP: 0xDFE6C29E ( http://keyserver.veridis.com ) > Finger Print: 9482 448F C7C3 896C 1DFE 7DD3 2492 A7D0 DFE6 C29E > > ------------------------------------------------------------------------------ > Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS > and more. Get SQL Server skills now (including 2012) with LearnDevNow - > 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. > SALE $99.99 this month only - learn more at: > http://p.sf.net/sfu/learnmore_122512 > _______________________________________________ > rdesktop-devel mailing list > rde...@li... > https://lists.sourceforge.net/lists/listinfo/rdesktop-devel > --- Peter Åstrand ThinLinc Chief Developer Cendio AB http://cendio.com Teknikringen 8 http://twitter.com/ThinLinc 583 30 Linköping http://facebook.com/ThinLinc Phone: +46-13-214600 http://plus.google.com/112509906846170010689 |