Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#20 Missing break; statement

closed-fixed
James Nobis
None
5
2010-08-22
2010-08-22
No

Lines 482 to 486 in ChainWalkContext.cpp:

if(i < nCharsetLen) // We found the correct charset
{
m_Plain[i] = m_vCharset[j].m_PlainCharset[nIndexOfX % m_vCharset[j].m_nPlainCharsetLen];
nIndexOfX /= m_vCharset[j].m_nPlainCharsetLen;
}

should be:

if(i < nCharsetLen) // We found the correct charset
{
m_Plain[i] = m_vCharset[j].m_PlainCharset[nIndexOfX % m_vCharset[j].m_nPlainCharsetLen];
nIndexOfX /= m_vCharset[j].m_nPlainCharsetLen;
break;
}

As it is now, it fails to create correct reductions on any non-standard platforms.

Discussion

  • James Nobis
    James Nobis
    2010-08-22

    • assigned_to: nobody --> quelrod
    • status: open --> closed-fixed
     
  • James Nobis
    James Nobis
    2010-08-22

    You are correct and I have added the missing break and your name to the appropriate copyright information for the file. Out of curiosity what non x86/x86-64 platforms are you trying to use rcracki on?