#12 Allow abbreviated hashes in the UI

closed
nobody
5
2008-10-06
2008-06-17
Manuel Nickschas
No

Since git in most cases outputs only abbreviated hashes (and often, for example in CIA commit logs or version numbers, one also only gets abbreviated hashes), it should be possible to enter only the first few letters of a hash value in the appropriate field to jump to the corrensponding commit.

Currently, the UI only accepts full-length hashes.

Discussion

  • Logged In: YES
    user_id=787298
    Originator: NO

    I've implemented this in a local branch, but it needs review ... let's see how I can get this to Macro.

     
  • Marco Costalba
    Marco Costalba
    2008-08-28

    Logged In: YES
    user_id=1286020
    Originator: NO

    It is possible to search for a SHA substring (abbreviated sha) in the fielter field after selecting SHA1 in the search combobox on the top bar.

     
  • Marco Costalba
    Marco Costalba
    2008-08-28

    • status: open --> closed
     
  • Logged In: YES
    user_id=509175
    Originator: YES

    That is not very intuitive and not very comfortable though. The standard use case is that you only have an abbreviated hash (even the git CLI usually just announces abbreviated hashes). Using the search requires you to:

    - enter the SHA1 in the search box
    - select SHA1 in the combobox
    - press enter
    - mark the entry that shows up (otherwise it will go away again in the next step)
    - unselect the filter (such that you can actually see the tree again)

    Versus:

    - enter the abbreviated SHA1 in the SHA1 box (which is also the intuitive thing to do)
    - press enter

    Since eyebex has already implemented this, it can't be too hard to put that in mainline, I guess... I'd be very glad if you could make this common usecase easier for users!

    Otherwise, qgit4 is a great and very useful program, keep up the good work! :)

     
  • Marco Costalba
    Marco Costalba
    2008-08-29

    • status: closed --> open
     
  • Marco Costalba
    Marco Costalba
    2008-08-29

    Logged In: YES
    user_id=1286020
    Originator: NO

    Reopened due to user request.

    BTW the first patch of eyebex cannot be used as is, the second one needs some testing and review. I'll do that and I'll try to push a fix.

    Thanks for your feedback
    Marco

     
  • Logged In: YES
    user_id=787298
    Originator: NO

    I'm short of time currently, but I hope to be able to send an improved version of the second approach which addresses Marco's suggestions to him this week end.

     
  • Marco Costalba
    Marco Costalba
    2008-10-06

    • status: open --> closed
     
  • Marco Costalba
    Marco Costalba
    2008-10-06

    Patch from Sebastian Schuberth applied.