Re: [PyX-devel] [PATCH 1/2] add hiresbbox parameter to epsfile.epsfile constructor

[André W. <wo...@us...>]

Hi,

I'm sorry for being late in the discussion.

Am 22.07.2011 um 14:09 schrieb Michael J Gruber:

> hiresbbox=0 is the default, unchanged behaviour.
> hiresbbox=1 means that the high resolution bounding box (HiResBoundingBox)
> is used rather than the normal one (BoundingBox).

First of all thank you for your patch. We should certainly use the HiResBoundingBox. I agree to other comments in the thread to change the default to use the HiResBB (if available). While this is an incompatible change, it is for the better. PyX development allows for incompatible changes. While the graphical defect might need to be fixed for certain use-cases, I suggest to make this exceptional by a deprecation warning (just add a warnings.warn(...)). Furthermore I suggest to rename the parameter to "ignore_hiresbbox" and set it to False. While this is more verbose, it is a better description of what the parameter does. To summarize my point of view: We don't have a lowresbbox paramter and we don't need to add it.

As a side remark: PyX requires Python 2.3 now and we can use True and False. While we did not yet fix all the old code in this respect, we should use it for new code from the very beginning.

Any comment regarding the addition of the second part of the patch, the epsfile.epsfile example? Fine for me, even as an example, not just an gallery entry. However, I wonder whether we should demonstrate "ignore_hiresbbox". It could be a double dangerous bend signed paragraph, but we don't need to show it. This example will also display the bitmap based display of the embedded epsfile in the pdf output, which could (and should) be discussed by a double dangerous bend signed paragraph. It is fine to demonstrate this problem, as we need to work on a pdffile.pdffile functionality too (and it slightly increases the pressure). But for PDF there will never be a lowresbbox feature so the same functionality for epsfile should be an exception and to my mind even a deprecated feature.

Best,


André

-- 
by  _ _      _    Dr. André Wobst, Amselweg 22, 85716 Unterschleißheim
   / \ \    / )   wo...@us..., http://www.wobsta.de/
  / _ \ \/\/ /    PyX - High quality PostScript and PDF figures
 (_/ \_)_/\_/     with Python & TeX: visit http://pyx.sourceforge.net/