Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#108 All BOOLAPI_NL functions in win32event swallow errors

closed-fixed
nobody
None
5
2010-12-18
2010-12-13
Ziga Seilnacht
No

SetEvent, ResetEvent, ReleaseMutex and SetWaitableTimer can still fail even after their handle argument has been validated (e.g. if the handle is closed or if it is a handle to a different object than the one expected by the function).

The attached patch simply removes the BOOLAPI_NL and replaces it with error checking BOOLAPI. Tests are also included.

Discussion

  • Ziga Seilnacht
    Ziga Seilnacht
    2010-12-13

    Patch against current trunk

     
  • Mark Hammond
    Mark Hammond
    2010-12-18

    Awesome - thanks!

    Checking in win32/test/test_win32event.py;
    new revision: 1.4; previous revision: 1.3
    Checking in win32/src/win32event.i;
    new revision: 1.13; previous revision: 1.12
    Checking in CHANGES.txt;
    new revision: 1.66; previous revision: 1.65

     
  • Mark Hammond
    Mark Hammond
    2010-12-18

    • status: open --> closed-fixed