Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#89 Full LOGFONT struct implementation

closed-fixed
nobody
pythonwin (20)
5
2011-11-05
2011-11-05
Kris Hardy
No

The current implementation of the LOGFONT struct in Pythonwin/win32util.cpp is not complete, relative to the WinGDI.h in the Windows 7.1 SDK. Attached is a proposed patch to support the full LOGFONT struct.

Notes:
I reordered the szFont* static strings, the documentation, the dict building order in LogFontToDict(), and the LOGFONT packing order in DictToLogFont(). This was done purely for asthetics in order to have the orders match that of the LOGFONT struct.

Discussion

  • Mark Hammond
    Mark Hammond
    2011-11-05

    Thanks for the patches - a couple of notes:

    * CHANGES.txt should have these in the "Since 216" section - 217 is yet to be released. In that same file, please wrap the lines to 80 chars, remove the URL to MSDN and if you like, add your name at the end of the paragraph - something like "(feature request 3433757 by Kris Hardy)

    * Please remove the notes similar to "2011-11-02 Extended by Kris Hardy ..." - I prefer keeping those notes out of the code and let hg tell us that - if similar notes were added for every change it would get messy pretty quickly :) It is fine in the CHANGES file though, as mentioned above.

    * Pythonwin/win32util.cpp is indented with tabs where you have used spaces. Tabs should be used for consistency (oh - I see now the second patch does that)

    * In that same file, the existing comment:
    // ??? This is missing a lot of members ???
    is now out of date, right? If so it should be removed.

    If you can generate a single new patch with those changes I'll check it in!

    Thanks,

    Mark

     
  • Kris Hardy
    Kris Hardy
    2011-11-05

    Thanks for the review. Will do.

     
  • Kris Hardy
    Kris Hardy
    2011-11-05

    Combined Patch

     
    Attachments
  • Kris Hardy
    Kris Hardy
    2011-11-05

    The combined patch, complete with fixes, is attached.

     
  • Mark Hammond
    Mark Hammond
    2011-11-05

    • status: open --> closed-fixed
     
  • Mark Hammond
    Mark Hammond
    2011-11-05

    Checked in as rev 4169:2113b637ed40 - thanks!