#3 Indentation fix

closed-fixed
nobody
None
5
2007-06-10
2006-09-15
Nick Welch
No

Hi, I submitted a request last year to fix the
indentation of the source. It was turned down by
calroc99. I have re-indented the source for my own
sake and I figured I would submit a patch in case the
new maintainer wanted to apply it.

Everything is re-indented to 4 spaces. I tested the
changed code and everything in my two python-xlib apps
works, and all of the tests run successfully.

Discussion

  • Nick Welch
    Nick Welch
    2006-09-15

     
    Attachments
  • Mike Grant
    Mike Grant
    2006-11-22

    • status: open --> pending
     
  • Mike Grant
    Mike Grant
    2006-11-22

    Logged In: YES
    user_id=1175208
    Originator: NO

    Hi Nick,

    I'm definitely interested in fixing the indentation issues - I get some warnings when checking for tab/space problems with python -t. I tried applying the patch but had a few problems doing so (I probably suck). Could you regenerate it against the current CVS using something like "diff -ru python-xlib-cvs/ python-xlib-cvs+indentfixed/"?

     
  • Mike Grant
    Mike Grant
    2006-11-22

    Logged In: YES
    user_id=1175208
    Originator: NO

    (status reset to open from pending, since pending makes it disappear from the default view on the patches page - I don't want to forget this exists ;) )

     
  • Mike Grant
    Mike Grant
    2006-11-22

    • status: pending --> open
     
  • Mike Grant
    Mike Grant
    2007-06-10

    • status: open --> closed-fixed
     
  • Mike Grant
    Mike Grant
    2007-06-10

    Logged In: YES
    user_id=1175208
    Originator: NO

    tabnanny confirmed there were some confusing tabs/spaces. Used reindent.py from the standard Python distribution to convert all tabs to spaces (tabstop was 8 spaces, indent level is 4, as in the current codebase).