Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#13 various fixes

closed-rejected
nobody
None
5
2014-08-28
2004-01-12
Matthias Klose
No

[forwarded from http://bugs.debian.org/226337\]

Dave Love writes:

I made a load of changes to python-mode.el and realized
that several
of them fix (at least in Emacs 21) old Debian bugs:
160130, 209723,
164423, 164424 and 159628. Here's what I sent to
python-mode in case
it's useful.

This patch against recent CVS fixes/adds a bunch of
things, including:

* Runtime use of cl, per Emacs rules -- actually,
avoid it completely;
* Proper syntactic fontification in Emacs 21;
* Non-ASCII identifiers in Emacs 21;
* Missing cases for Emacs;
* Menu lossage in transient-mark-mode;
* Char tables not defined in the approved way (so you
can M-C-x them);
* Hooks not local that need to be;
* Hooks not removed when unloading;
* Losing use of `py-shell-alist';
* Compilation warnings.

This is mostly for Emacs 21, but as far as I can tell,
it hasn't broken anything in XEmacs.

Note that the licence is inconsistent with the use of
GPL'ed code in bits copied from elsewhere.

2003-12-01 Dave Love <fx@gnu.org>

* python-mode.el: Doc fixes.
(custom, cl, compile): Don't require.
(compile-internal): Autoload.
(comint-last-input-end): Defvar when compiling.
(py-char-classes-p): New.
(python-font-lock-keywords, py-defun-start-re,
py-class-start-re)
(py-pdbtrack-stack-entry-regexp,
py-imenu-class-regexp)
(py-imenu-method-regexp,
py-forward-into-nomenclature): Use it.
(py-quote-syntax, py-font-lock-syntactic-keywords)
(py-mark-active, py-outline-level,
python-mode-unload-hook): New.
(py-keep-region-active, py-electric-delete):
Avoid compilation
warning in Emacs.
(py-highlight-line, py-mouseto-exception): Add
Emacs case.
(py-in-literal): Define separate cases for
Emacs and XEmacs, and
avoid warning. Simplify Emacs case.
(py-fast-in-literal): Deleted.
(py-which-shell, py-which-args,
py-which-bufname): Move before
use.
(python-mode): Set
parse-sexp-lookup-properties, outline-regexp,
outline-level,
open-paren-in-column-0-is-defun-start. Modify
font-lock-defaults value.
(py-pdbtrack-track-stack-file): Bind
target_buffer.
(py-pdbtrack-grub-for-buffer): Bind buf, not
curbuf.
(py-output-buffer): defvar, not defconst.
(py-help-at-point): Avoid `search'.
(py-temp-directory): Maybe use
temporary-file-directory.
(py-menu, py-shift-region-left,
py-shift-region-right): Fix use of
`(mark)'.
(py-beginning-of-def-or-class): Re-run if it
lands in a string.
(py-goto-beginning-of-tqs): Don't lose if delim
is t.
(py-shell-alist): Don't quote cdrs.
(py-mode-map, py-shell-map, py-mode-output-map)
(py-mode-syntax-table,
py-dotted-expression-syntax-table): Define
inside defvar.
(py-imenu-create-index-engine): Avoid `first',
`second'.
(py-choose-shell-by-shebang): Use
py-shell-alist correctly.
(py-shell): Only add to
comint-output-filter-functions locally.
Set indent-line-function.
(py-execute-region): Fix choosing shell.
(py-mark-block): Activate mark.
(py-python-version): New. Use it with
info-lookup-maybe-add-help.
(debug-ignored-errors): Add errors used here.
(py-shell-map): Don't bind tab.
(py-pychecker-run): Use read-shell-command
conditionally.
(py-mode-output-map): Maybe bind mouse-2. Use
suppress-keymap.

Discussion

  • Matthias Klose
    Matthias Klose
    2004-01-12

     
    Attachments
  • Skip Montanaro
    Skip Montanaro
    2004-01-28

    Logged In: YES
    user_id=44345

    What version of python-mode.el was this patch made against?
    Applying it with patch fails pretty miserably. The reject file is
    490 lines and it looks like it will be almost impossible for me
    to sort out.

     
  • Skip Montanaro
    Skip Montanaro
    2005-06-04

    • status: open --> closed-rejected
     
  • Skip Montanaro
    Skip Montanaro
    2005-06-04

    Logged In: YES
    user_id=44345

    Closing. It's old (out-of-date) and contains GPL'd code which (as I
    understand it) would make it impossible to release with the Python
    distribution.