From: Adam C P. IV <haz...@de...> - 2010-06-11 13:50:21
|
It's perfect, thank you. (I'll separate it into two patches for the package.) -Adam On Thu, 2010-06-10 at 23:22 +0200, Dominique Orban wrote: > Hi Adam, > > I attach a patch fixing the string exception issue. This patch also > adds a line in a documentation file (entirely unrelated and remarkably > inconsequential---feel free to ignore). > > Does this work for you? > > Cheers, > Dominique > > On Thu, Jun 10, 2010 at 9:55 PM, Adam C Powell IV <haz...@de...> wrote: > > Hello Dominique, > > > > Debian is supposed to be in freeze soon, so if we can get a fix in > > within the next couple of weeks that would be great. > > > > That said, it might be best for both Debian and PySparse if you can just > > generate a patch to fix this without needing to do a new release. > > > > Thanks, > > Adam > > > > On Thu, 2010-06-10 at 09:08 +0200, Dominique Orban wrote: > >> Adam, > >> > >> Thank you for pointing this out. That seems to be the only string > >> exception in Pysparse and it has gone unnoticed for a long time. I > >> removed it and updated the source tree. > >> > >> We are in the process of merging major changes into trunk. The > >> directory layout is affected, as is the namespace. What is best for > >> the Deb package? Would you rather wait for the merge to complete and > >> have the new release, or have an updated release that includes this > >> simple fix? > >> > >> Dominique > >> > >> > >> On Thu, Jun 10, 2010 at 12:35 AM, Adam C Powell IV <haz...@de...> wrote: > >> > Hello PySparse group, > >> > > >> > Just received this bug report from the Debian bug tracking system. Are > >> > string exceptions important to pysparse? If so, this will be an issue > >> > for python 2.6 and beyond. > >> > > >> > -Adam > >> > > >> > -------- Forwarded Message -------- > >> >> From: Sandro Tosi <mo...@ra...> > >> >> Reply-to: Sandro Tosi <mo...@ra...>, > >> >> 585...@bu... > >> >> To: mai...@bu... > >> >> Subject: Bug#585330: python-sparse: Python string exceptions no more > >> >> allowed in Python 2.6 > >> >> Date: Wed, 09 Jun 2010 22:19:39 +0000 > >> >> > >> >> Package: python-sparse > >> >> Version: 1.1-1+b1 > >> >> Severity: minor > >> >> User: deb...@li... > >> >> Usertags: python2.6 > >> >> > >> >> Hello, > >> >> One of the changes brought by Python 2.6 is the removal of string > >> >> exceptions, so they won't work in Python 2.6 (just a side note: they > >> >> were also buggy before, since they were not guaranteed to work > >> >> reliable even in <2.6); as an example: > >> >> > >> >> $ python2.5 -c "raise 'eggs'" > >> >> -c:1: DeprecationWarning: raising a string exception is deprecated > >> >> Traceback (most recent call last): > >> >> File "<string>", line 1, in <module> > >> >> eggs > >> >> > >> >> $ python2.6 -c "raise 'eggs'" > >> >> Traceback (most recent call last): > >> >> File "<string>", line 1, in <module> > >> >> TypeError: exceptions must be old-style classes or derived from BaseException, not str > >> >> > >> >> Since 2.6 is the planned default version for the upcoming new Debian > >> >> stable release, there are chances your package may be affected by this > >> >> change. > >> >> > >> >> We are not sure your package is impacted, since the exception raise > >> >> can be in a dead or very rare branch of the code, and so simply never > >> >> being executed. We would like to leverage your package maintainer > >> >> status and the relationship with upstream authors to inspect more > >> >> deeply the issue and act accordingly (that includes: making this bug > >> >> release critical, closing it as irrelevant, tagging it 'wontfix', or > >> >> whatever is appropriate). > >> >> > >> >> Jakub Wilk made the discovery of the problem and kindly prepared a > >> >> list [1] of all identified packages (downloaded on 2010-06-09) along > >> >> with files & lines that triggered the pattern search. > >> >> > >> >> [1] http://people.debian.org/~morph/strexp/string-exceptions.lintian > >> >> > >> >> This mass-bug filing was announced at 2010-06-06 on [2] (see the > >> >> thread and the references there). > >> >> > >> >> [2] http://lists.debian.org/debian-devel/2010/06/msg00097.html > >> >> > >> >> We do not consider the whole situation a stopper for the Python > >> >> transition to 2.6, except (of course) for those single bugs where > >> >> severity will be increased. > >> >> > >> >> Thanks in advance for your attention, > >> >> Sandro on behalf of debian-python -- GPG fingerprint: D54D 1AEE B11C CE9B A02B C5DD 526F 01E8 564E E4B6 Engineering consulting with open source tools http://www.opennovation.com/ |