Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.
I've added errno to SerialException, so it is possible to read it when catching it in apps using pyserial.
open: Pass errno from IOError to SerialException
is the patch incomplete? it just adds an argument to the exception, which would alter the output when the exception is printed.
also this error number would not be portable across platforms, so a program relying on it would fail, e.g. on Windows.
Forgive me, if I've done anything wrong, but I believe I'm right.
List of facts:
Therefor, it has no reason at all to inherit form IOError. If you want to inherit something, it should follow the rule of "is" - SerialException is an IOError. Is it? If so, it should contain an error number.
If my imaginary app catches IOError, it except an error number. When SerialException is raised, it is caught (because it inherits from IOError), but no errno is there. I cannot tell the user politely, what wen't wrong and what should (s)he do. Only thing I can do, is to show the error message.
except SerialException as e:
# Currently, there is no errno, but it should be there in the future
if e.errno == 2:
print _("Error: You are trying to connect to a non-exisiting port.")
elif e.errno == 8:
print _("Error: You don't have permission to open %s.") % port
print _("You might need to add yourself to the dialout group.")
Passing errno to IOError or it's ancestors is not obligatory, of course, but the problem is: you have the number (from IOError) already. Why do you throw it away?
About the cross platform incompatibility - I believe also on Windows there is a IOError error number, but the fact it, I might be wrong. If this is the case, basically just check if msg.errno exists and pass it along only if it does.
raise SerialException(msg.errno, "could not open port %s: %s" % (self._port, msg))
raise SerialException("could not open port %s: %s" % (self._port, msg))
But I donẗ think this aproach will work, because as far as I know, IOError always has (at least an empty) errno:
In : ioe = IOError()
In : ioe.errno
In : ioe.blahblah
AttributeError Traceback (most recent call last)
<ipython-input-3-5b821a12d5ce> in <module>()
----> 1 ioe.blahblah
AttributeError: 'exceptions.IOError' object has no attribute 'blahblah'
OK, accepted, though that only adds that feature only for posix.
Personally, I'd recommend against evaluating errno or trying to show very specific error messages as this is not possible in a simple, cross platform way, and the point of pySerial is, to some extent, that it's easy to run the same program on different platforms (at least on posix it would be easy to use the serial port directly).