Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#29 Small bugs found by PyDev

closed
nobody
None
3
2008-11-05
2008-10-29
Eike Welk
No

These are small bugs found by the PyDev editor. They are all in code that (probably) never gets executed by me.

Line 213 (ParseSyntaxException.__init__): Wrong base class __init__ called. Patch is attached.

Line 377 (ParseResults.insert): Unknown variable "j". I don't understand the method and can't fix it.

Discussion

  • Eike Welk
    Eike Welk
    2008-10-29

    • priority: 5 --> 3
     
  • Eike Welk
    Eike Welk
    2008-10-29

    the patch

     
    Attachments
  • Eike Welk
    Eike Welk
    2008-10-29

    File Added: diff_small_bug_1.txt

     
  • Paul McGuire
    Paul McGuire
    2008-11-05

    • status: open --> closed
     
  • Paul McGuire
    Paul McGuire
    2008-11-05

    The diff for Line 213 pertains to the __init__ method for ParseSyntax Exception, and reads in part:

    def __init__(self, pe):
    - super(ParseSyntaxException, self).__init__(
    - pe.pstr, pe.loc, pe.msg, pe.parserElement)
    + ParseFatalException.__init__(self, pe.pstr, pe.loc, pe.msg, pe.parserElement)

    ParseFatalException *is* the superclass of ParseSyntaxException. I prefer to use super to hardcoding the actual superclass.

    The variable "j" bug on line 377 was fixed in v1.5.1.

    Thanks for submitting, I will close this bug request.
    -- Paul